Repository navigation
Conversation
This is a follow-up to the previous commit [1] for google#1627, which started passing /DEPENDENTLOADFLAG:0x100 when linking the ARM64X pure forwarder DLL (mozc_tip64x.dll). As already pointed out in google#1627, MSVC link.exe (as of 14.52.37025) writes DependentLoadFlags only into the load config of the ARM64 view, leaving it 0 in the x64 (ARM64EC) view. As a result, x64 processes running on ARM64 Windows were not covered by that fix. lld-link sets it in both views. link.exe lld-link ARM64 view 0x100 0x100 x64 (ARM64EC) view 0x0 0x100 With this commit, build_tip_forwarder_dll.py uses clang-cl and lld-link instead of cl.exe and link.exe. Other than that, this commit also addresses pyrefly lint errors. [1]: f120a75
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up to the previous commit (f120a75) for #1627, which started passing
/DEPENDENTLOADFLAG:0x100when linking the ARM64X pure forwarder DLL (mozc_tip64x.dll).As already pointed out in #1627, MSVC
link.exe(as of 14.52.37025) writesDependentLoadFlagsonly into the load config of the ARM64 view, leaving it0in the x64 (ARM64EC) view. As a result, x64 processes running on ARM64 Windows were not covered by that fix.lld-linksets it in both views.link.exelld-link0x1000x1000x00x100With this commit, build_tip_forwarder_dll.py uses
clang-clandlld-linkinstead of cl.exe and link.exe.Other than that, this commit also addresses
pyreflylint errors.Issue IDs
mozc_tip64x.dllshould haveLOAD_LIBRARY_SEARCH_DLL_LOAD_DIRin itsDependentLoadFlags#1627Steps to test new behaviors (if any)
mozc_tip64x.dll.llvm-readobj --coff-load-config bazel-bin\win32\tip\mozc_tip64x.dll.DependentLoadFlags: 0x100is shown twice: once for the ARM64 view and once underHybridObject(the x64 view). It was0x0underHybridObjectbefore this PR.bazel-bin\win32\installer\Mozc64.msion ARM64 Windows.AMD64 True True. It wasAMD64 True Falsebefore this PR.mozc_tip64x.dllshould haveLOAD_LIBRARY_SEARCH_DLL_LOAD_DIRin itsDependentLoadFlags#1627), and in x64 apps.