Repository navigation
Conversation
yukawa
force-pushed
the
append_unaligned
branch
from
November 5, 2026 10:09
b7111fb to
67d2fb0
Compare
yukawa
force-pushed
the
append_unaligned
branch
from
November 21, 2026 06:14
67d2fb0 to
29271b8
Compare
This commit aims to generalize a common code pattern observed in the repository without changing user-visible behavior. The pattern we discuss here is appending integers to std::string in the native byte order, which is common around data serialization and packed data file generation. There is no behavior change on any platform, and the generated data is unchanged.
yukawa
force-pushed
the
append_unaligned
branch
from
November 21, 2026 06:17
29271b8 to
41178cf
Compare
Collaborator
Author
|
Also rebased onto master to address merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit aims to generalize a common code pattern observed in the repository without changing user-visible behavior.
The pattern we discuss here is appending integers to
std::stringin the native byte order, which is common around data serialization and packed data file generation.There is no behavior change on any platform, and the generated data is unchanged.
Issue IDs
N/A
Steps to test new behaviors