Repository navigation
Conversation
The CA interaction test connected to www.nodejs.org without sending a TLS server name. The endpoint returned its default nodejs.org certificate, which did not cover www.nodejs.org, so hostname verification failed before the test could check the supplied CA behavior. Send www.nodejs.org as the server name while preserving the hostname, certificate verification and all CA assertions. Apply the correction in the runtime image and include the patched test in its syntax checks. Assisted-by: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Node.js CA interaction test connects to www.nodejs.org without
sending a TLS server name. The endpoint can return its default nodejs.org
certificate, which does not cover www.nodejs.org, so hostname verification
fails before the test checks the supplied CA behavior.
Apply the correction proposed in nodejs/node#66835 to the
runtime image. Send www.nodejs.org as the server name while preserving the
hostname, certificate verification, and all CA assertions. Include the
patched test in the existing image syntax checks.
The fresh source image and complete declared gVisor Node.js runtime profile
passed in both filesystem modes: 160 runtime shards and 7,898 inner tests.
This qualification used the source-image integration branch and retains
the profile's existing exclusions. The earlier focused affected-partition
run also passed. Upstream Node metadata checks have passed; these gVisor
results do not establish a full upstream Node source-suite result.
Assisted by OpenAI Codex.