Repository navigation
Preserve moved TUN devices across restore - #15942
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test/cl1001712722
branch
2 times, most recently
from
October 22, 2026 02:00
d427da3 to
66c8329
Compare
The TUN save/restore support in 8bf3dc4 classified preserved NICs by kind, but moving a NIC to another network namespace discarded that kind. A moved TUN device was consequently removed during checkpoint. Its restored close callback also retained the original stack and NIC ID, rather than the destination chosen by the move. Keep the kind when moving a NIC. Restore its close callback in the stack that owns the preserved NIC, and remove the stale ownership fields from the TUN endpoint. Extend the syscall coverage to move a TUN device before checkpoint and verify its removal when the restored device is closed. Assisted-by: OpenAI Codex <!-- codex-thread: 01a0680f-bbf5-7511-95f7-4414f4e10d2e --> FUTURE_COPYBARA_INTEGRATE_REVIEW=#15315 from tamird:tun-restore-after-netns-move ae6e695 PiperOrigin-RevId: 1001712722
copybara-service
Bot
force-pushed
the
test/cl1001712722
branch
from
October 22, 2026 03:08
66c8329 to
e0ffc0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve moved TUN devices across restore
The TUN save/restore support in 8bf3dc4 classified preserved NICs by
kind, but moving a NIC to another network namespace discarded that kind.
A moved TUN device was consequently removed during checkpoint. Its
restored close callback also retained the original stack and NIC ID,
rather than the destination chosen by the move.
Keep the kind when moving a NIC. Restore its close callback in the stack
that owns the preserved NIC, and remove the stale ownership fields from
the TUN endpoint. Extend the syscall coverage to move a TUN device
before checkpoint and verify its removal when the restored device is
closed.
Assisted-by: OpenAI Codex
FUTURE_COPYBARA_INTEGRATE_REVIEW=#15315 from tamird:tun-restore-after-netns-move ae6e695