Repository navigation
Make FFN subvolume checkpointing and preemption resume deterministically: - #155
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_1025452684
branch
from
November 20, 2026 10:39
d9c40ec to
a4f9a7f
Compare
…lly: - Track the popped in-flight FoV candidate in `FaceMaxMovementPolicy` and re-queue it at the head of `scored_coords` if checkpointed before `update()` completes. - Rewind `seed_policy` (`in_progress_seed=True`) when checkpointing on `TerminationException` at `num_iters == 0` or at pre-segment periodic checkpoints, and check `is_shutting_down()` between seeds in `Canvas.segment_all`. - Serialize nested `movement_policy` and `seed_policy_state` objects as 0-d object arrays in `Canvas.save_checkpoint`, serialize saves with a reentrant `Canvas.io_lock`, and preserve `_max_id` and integer `partial_segment_iters` on restore. - Evaluate `SequentialPolicies` sub-policies lazily so later stages see earlier stages' segmentation, and rewind only the active sub-policy on in-progress checkpoints. - Make `ThreadingExecutorClient.finish` and `ThreadingBatchExecutor.stop_server` idempotent when `exit_request` is already set, and clear `Runner.canvases` entries in a `finally` block. PiperOrigin-RevId: 1026329651
copybara-service
Bot
force-pushed
the
test_1025452684
branch
from
November 20, 2026 10:54
a4f9a7f to
29fbe28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make FFN subvolume checkpointing and preemption resume deterministically:
FaceMaxMovementPolicyand re-queue it at the head ofscored_coordsif checkpointed beforeupdate()completes.seed_policy(in_progress_seed=True) when checkpointing onTerminationExceptionatnum_iters == 0or at pre-segment periodic checkpoints, and checkis_shutting_down()between seeds inCanvas.segment_all.movement_policyandseed_policy_stateobjects as 0-d object arrays inCanvas.save_checkpoint, serialize saves with a reentrantCanvas.io_lock, and preserve_max_idand integerpartial_segment_iterson restore.SequentialPoliciessub-policies lazily so later stages see earlier stages' segmentation, and rewind only the active sub-policy on in-progress checkpoints.ThreadingExecutorClient.finishandThreadingBatchExecutor.stop_serveridempotent whenexit_requestis already set, and clearRunner.canvasesentries in afinallyblock.