Repository navigation
Resolve canonical owner of static imports to the most general accessible supertype. - #6203
Merged
Merged
Conversation
…ble supertype. `StaticImports.tryCreate` previously resolved the canonical owner of an imported static member directly to `member.owner` without verifying whether that declaring type is accessible from the package of the importing compilation unit. When a public type inherits constants from a package-private supertype or super-interface (such as protobuf `large_enum = true` shard interfaces), `NonCanonicalStaticMemberImport` suggested importing from the inaccessible package-private type outside its package. Walk `types.closure(baseType.type)` in `canonicalOwner` to select the most general supertype that is a subtype of `member.owner` and whose type (and any enclosing types) is accessible from the importing package, and only treat a single imported `ClassSymbol` as a canonical type import when it is similarly accessible from the importing package. PiperOrigin-RevId: 998810316
copybara-service
Bot
force-pushed
the
test_994361319
branch
from
October 13, 2026 19:21
b02516c to
08e222c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve canonical owner of static imports to the most general accessible supertype.
StaticImports.tryCreatepreviously resolved the canonical owner of an imported static member directly tomember.ownerwithout verifying whether that declaring type is accessible from the package of the importing compilation unit. When a public type inherits constants from a package-private supertype or super-interface (such as protobuflarge_enum = trueshard interfaces),NonCanonicalStaticMemberImportsuggested importing from the inaccessible package-private type outside its package.Walk
types.closure(baseType.type)incanonicalOwnerto select the most general supertype that is a subtype ofmember.ownerand whose type (and any enclosing types) is accessible from the importing package, and only treat a single importedClassSymbolas a canonical type import when it is similarly accessible from the importing package.