Repository navigation
Use cargo xtask commands in the unsafe deep dive setup page - #3320
Open
ZainnQureshii wants to merge 1 commit into
Open
ZainnQureshii wants to merge 1 commit into
ZainnQureshii wants to merge 1 commit into
Conversation
google#2847 removed the `install-tools` and `serve` cargo aliases, so `cargo install-tools` and `cargo serve` on this page now fail with "no such command". Use `cargo xtask install-tools` and `cargo xtask serve`, as the README does, and point to the README's setup prerequisites, since `install-tools` runs Bazel.
There was a problem hiding this comment.
Code Review
This pull request updates the setup instructions in src/unsafe-deep-dive/setup.md to correctly use 'cargo xtask install-tools' and 'cargo xtask serve' instead of 'cargo install-tools' and 'cargo serve'. It also adds a note indicating that 'cargo xtask install-tools' requires the prerequisites listed in the repository's README, including Bazel. I have no feedback to provide.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "(Optional) Create a local instance of the course" block in the Unsafe deep dive setup page (
src/unsafe-deep-dive/setup.md) usescargo install-toolsandcargo serve. Those cargo aliases were removed in #2847:.cargo/config.tomlnow defines onlyxtask, so both commands fail with "no such command".Changes:
cargo install-tools->cargo xtask install-toolscargo serve->cargo xtask serveThese match the README's Setup and Commands sections (
README.md:75,README.md:87-88) and theInstallToolsandServesubcommands inxtask/src/main.rs.install-toolsrunsbazel build(xtask/src/main.rs:153), and this page's own Bazel note is inside an HTML comment, so a learner without Bazel would still fail at that step.Ran in a clone of
main(stable Rust):dprint checkpasses on the page. The fullinstall-toolsandserveruns (Bazel build) were not done.Prepared with AI assistance (Claude Code) and reviewed with GitHub Copilot.
🤖 Generated with Claude Code