Repository navigation
graphics_detector: use size_t for image dimensions and coordinates - #3626
Merged
adelva1984 merged 1 commit intoNov 18, 2026
Merged
Conversation
ser-io
approved these changes
Nov 18, 2026
jmacnak
approved these changes
Nov 18, 2026
Switch image dimensions, coordinates, and buffer offset calculations in `image.h` and `image.cpp` from `uint32_t` to `size_t` to resolve CodeQL `cpp/integer-multiplication-cast-to-long` alerts where `uint32_t` multiplications could overflow before widening to `size_t`. Assisted-by: Jetski:Gemini
adelva1984
force-pushed
the
fix/graphics-detector-image-overflow
branch
from
November 18, 2026 21:29
bb79f8d to
b641152
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches image dimensions, coordinates, and buffer offset calculations in
base/cvd/cuttlefish/host/graphics_detector/image.handimage.cppfromuint32_ttosize_t.This resolves CodeQL
cpp/integer-multiplication-cast-to-longalerts ("Multiplication result may overflow 'unsigned int' before it is converted to 'size_type'") onimage.cpp:77,210,258,259, and260, as well as related stride/offset calculations.