Repository navigation
Conversation
Adds a DiceHandover config (build, addr, and an acpi_table or device_tree_overlay firmware table). When set, the parser emits --crosvm_file_backed_mapping_base64 for the build plus --crosvm_acpi_table or --crosvm_device_tree_overlay for the table. The mapping is always 64K, which covers the guest page size on all platforms. The firmware table type is set in the config because the parser does not know the guest arch. Remote (@ab/...) builds are validated but not yet passed to launch, since cvd fetch does not support them. Bug: 544996625 Bug: 539399873 Test: bazel test //cuttlefish/host/commands/cvd/cli/parser/... Assisted-by: Jetski:Gemini TAG=agy CONV=ef35cb23-c351-4dd9-9690-b254baa904be
Adds the --dice_handover_build vector flag to cvd fetch to download remote dice handover artifacts into the instance target directory as "dice_handover". Plumbs disk_artifacts.dice_handover.build from the environment config to --dice_handover_build in cvd fetch when prefixed with @ab/, and emits --crosvm_file_backed_mapping_base64 (referencing "dice_handover") together with --crosvm_acpi_table or --crosvm_device_tree_overlay for remote dice handover builds. Bug: 544996625 Bug: 539399873 Test: bazel test //cuttlefish/host/commands/cvd/fetch/... //cuttlefish/host/commands/cvd/cli/parser/... Assisted-by: Jetski:Gemini TAG=agy CONV=2c56bbf3-4b99-4b50-9540-fa2772eae864
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the --dice_handover_build vector flag to cvd fetch to download
remote dice handover artifacts into the instance target directory as
"dice_handover".
Plumbs disk_artifacts.dice_handover.build from the environment config
to --dice_handover_build in cvd fetch when prefixed with @ab/, and
emits --crosvm_file_backed_mapping_base64 (referencing "dice_handover")
together with --crosvm_acpi_table or --crosvm_device_tree_overlay for
remote dice handover builds.
Bug: 544996625
Bug: 539399873
Test: bazel test //cuttlefish/host/commands/cvd/fetch/... //cuttlefish/host/commands/cvd/cli/parser/...
Assisted-by: Jetski:Gemini
TAG=agy
CONV=2c56bbf3-4b99-4b50-9540-fa2772eae864