Skip to content

cvd: support fetching remote dice_handover builds in cvd fetch - #3581

Open
erjiaqing wants to merge 2 commits into
google:mainfrom
erjiaqing:510177847-p3
Open

erjiaqing wants to merge 2 commits into
google:mainfrom
erjiaqing:510177847-p3

Conversation

@erjiaqing

Copy link
Copy Markdown
Contributor

Adds the --dice_handover_build vector flag to cvd fetch to download
remote dice handover artifacts into the instance target directory as
"dice_handover".

Plumbs disk_artifacts.dice_handover.build from the environment config
to --dice_handover_build in cvd fetch when prefixed with @ab/, and
emits --crosvm_file_backed_mapping_base64 (referencing "dice_handover")
together with --crosvm_acpi_table or --crosvm_device_tree_overlay for
remote dice handover builds.

Bug: 544996625
Bug: 539399873

Test: bazel test //cuttlefish/host/commands/cvd/fetch/... //cuttlefish/host/commands/cvd/cli/parser/...
Assisted-by: Jetski:Gemini
TAG=agy
CONV=2c56bbf3-4b99-4b50-9540-fa2772eae864

Note: This PR is based on #3390, the first commit is #3390 , I will rebase the PR to remove it after #3390 is merged.

Adds a DiceHandover config (build, addr, and an acpi_table or
device_tree_overlay firmware table). When set, the parser emits
--crosvm_file_backed_mapping_base64 for the build plus
--crosvm_acpi_table or --crosvm_device_tree_overlay for the table.

The mapping is always 64K, which covers the guest page size on all
platforms. The firmware table type is set in the config because the
parser does not know the guest arch. Remote (@ab/...) builds are
validated but not yet passed to launch, since cvd fetch does not
support them.

Bug: 544996625
Bug: 539399873

Test: bazel test //cuttlefish/host/commands/cvd/cli/parser/...
Assisted-by: Jetski:Gemini
TAG=agy
CONV=ef35cb23-c351-4dd9-9690-b254baa904be
Adds the --dice_handover_build vector flag to cvd fetch to download
remote dice handover artifacts into the instance target directory as
"dice_handover".

Plumbs disk_artifacts.dice_handover.build from the environment config
to --dice_handover_build in cvd fetch when prefixed with @ab/, and
emits --crosvm_file_backed_mapping_base64 (referencing "dice_handover")
together with --crosvm_acpi_table or --crosvm_device_tree_overlay for
remote dice handover builds.

Bug: 544996625
Bug: 539399873

Test: bazel test //cuttlefish/host/commands/cvd/fetch/... //cuttlefish/host/commands/cvd/cli/parser/...
Assisted-by: Jetski:Gemini
TAG=agy
CONV=2c56bbf3-4b99-4b50-9540-fa2772eae864

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant