Skip to content

Clean up after a killed/signalled cvdalloc and default allocd to netlink - #3578

Open
dxapd wants to merge 4 commits into
google:mainfrom
dxapd:nftables-crash-cleanup
Open

dxapd wants to merge 4 commits into
google:mainfrom
dxapd:nftables-crash-cleanup

Conversation

@dxapd

@dxapd dxapd commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Last cvdalloc pr before we can start looking into deployment.

@dxapd dxapd changed the title Clean up after a killed cvdalloc and default allocd to netlink Clean up after a killed/signalled cvdalloc and default allocd to netlink Nov 12, 2026
@dxapd
dxapd requested a review from 3405691582 November 16, 2026 15:15
@dxapd
dxapd marked this pull request as ready for review November 16, 2026 15:15
@dxapd dxapd added the kokoro:run Run e2e tests. label Nov 17, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:run Run e2e tests. label Nov 17, 2026

@3405691582 3405691582 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should split this up into multiple commits. It's hard to reason why some of the changes e.g. in the netlink driver are necessary and/or connected to the cvdalloc changes.

Comment thread base/cvd/allocd/alloc_utils.cpp Resolved
Comment thread base/cvd/allocd/alloc_utils.cpp Resolved
Comment thread base/cvd/allocd/BUILD.bazel Resolved

constexpr const char* kTapKinds[] = {"mtap", "wtap", "wifiap", "etap"};

bool OwnerAlive(int id) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Belongs in the driver, probably?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would prefer not to do this - i wanted cvdalloc to be the part managing NftNatTables.

@dxapd
dxapd force-pushed the nftables-crash-cleanup branch from 75b582b to ac2623e Compare November 18, 2026 21:56

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants