Repository navigation
Conversation
dxapd
marked this pull request as ready for review
November 16, 2026 15:15
3405691582
reviewed
Nov 18, 2026
3405691582
left a comment
Collaborator
There was a problem hiding this comment.
I think you should split this up into multiple commits. It's hard to reason why some of the changes e.g. in the netlink driver are necessary and/or connected to the cvdalloc changes.
|
|
||
| constexpr const char* kTapKinds[] = {"mtap", "wtap", "wifiap", "etap"}; | ||
|
|
||
| bool OwnerAlive(int id) { |
Collaborator
There was a problem hiding this comment.
Belongs in the driver, probably?
Collaborator
Author
There was a problem hiding this comment.
would prefer not to do this - i wanted cvdalloc to be the part managing NftNatTables.
dxapd
force-pushed
the
nftables-crash-cleanup
branch
from
November 18, 2026 21:56
75b582b to
ac2623e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last cvdalloc pr before we can start looking into deployment.