Skip to content

assemble_cvd: support relative paths for crosvm_acpi_table, crosvm_device_tree_overlay, and crosvm_file_backed_mapping - #3234

Queued
erjiaqing wants to merge 2 commits into
google:mainfrom
erjiaqing:510177847-p2.2
Queued

erjiaqing wants to merge 2 commits into
google:mainfrom
erjiaqing:510177847-p2.2

Conversation

@erjiaqing

@erjiaqing erjiaqing commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Currently, crosvm_acpi_table, crosvm_device_tree_overlay and
crosvm_file_backed_mapping only work with absolute paths.

This change modifies the behavior by not just proxying the values, but
also checking system_image_dir when a relative path is passed. This
should be useful when using and sharing config files.

Bug: 544996625
Bug: 539399873
Bug: 510177847
Test: bazel test //cuttlefish/host/commands/assemble_cvd/...

TAG=agy
CONV=5d08e900-4fb1-44ec-b4fb-1a3cc848cdd2

@erjiaqing
erjiaqing marked this pull request as draft September 24, 2026 15:56
@erjiaqing
erjiaqing marked this pull request as ready for review September 28, 2026 10:11
@Databean Databean added the kokoro:run Run e2e tests. label Oct 1, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:run Run e2e tests. label Oct 1, 2026
@erjiaqing
erjiaqing force-pushed the 510177847-p2.2 branch 2 times, most recently from d84a901 to 739fa02 Compare October 22, 2026 09:14
@bridadan
bridadan requested a review from Databean October 23, 2026 20:41
@erjiaqing
erjiaqing force-pushed the 510177847-p2.2 branch 2 times, most recently from 9a80293 to 739fa02 Compare November 3, 2026 08:55
@rmuthiah rmuthiah added kokoro:force-run Trigger a presubmit build unconditionally. kokoro:run Run e2e tests. labels Nov 7, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed kokoro:run Run e2e tests. kokoro:force-run Trigger a presubmit build unconditionally. labels Nov 7, 2026
@adelva1984 adelva1984 added the kokoro:force-run Trigger a presubmit build unconditionally. label Nov 17, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:force-run Trigger a presubmit build unconditionally. label Nov 17, 2026
erjiaqing and others added 2 commits November 17, 2026 16:06
…vice_tree_overlay, and crosvm_file_backed_mapping

Currently, crosvm_acpi_table, crosvm_device_tree_overlay and
crosvm_file_backed_mapping only work with absolute paths.

This change modifies the behavior by not just proxying the values, but
also checking `system_image_dir` when a relative path is passed. This
should be useful when using and sharing config files.

On Android, the targets can use BOARD_CUSTOMIMAGES_PARTITION_LIST to
include the required files in `system_image_dir`.

TAG=agy
CONV=5d08e900-4fb1-44ec-b4fb-1a3cc848cdd2
@adelva1984
adelva1984 enabled auto-merge November 17, 2026 18:12
@adelva1984
adelva1984 disabled auto-merge November 18, 2026 21:42
@adelva1984
adelva1984 enabled auto-merge November 18, 2026 21:42
@adelva1984 adelva1984 added the kokoro:force-run Trigger a presubmit build unconditionally. label Nov 18, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:force-run Trigger a presubmit build unconditionally. label Nov 18, 2026
@adelva1984
adelva1984 disabled auto-merge November 19, 2026 02:45
@adelva1984
adelva1984 added this pull request to the merge queue Nov 19, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants