Repository navigation
Conversation
erjiaqing
marked this pull request as draft
September 24, 2026 15:56
erjiaqing
marked this pull request as ready for review
September 28, 2026 10:11
erjiaqing
force-pushed
the
510177847-p2.2
branch
2 times, most recently
from
October 22, 2026 09:14
d84a901 to
739fa02
Compare
erjiaqing
force-pushed
the
510177847-p2.2
branch
2 times, most recently
from
November 3, 2026 08:55
9a80293 to
739fa02
Compare
bridadan
approved these changes
Nov 5, 2026
Databean
approved these changes
Nov 17, 2026
…vice_tree_overlay, and crosvm_file_backed_mapping Currently, crosvm_acpi_table, crosvm_device_tree_overlay and crosvm_file_backed_mapping only work with absolute paths. This change modifies the behavior by not just proxying the values, but also checking `system_image_dir` when a relative path is passed. This should be useful when using and sharing config files. On Android, the targets can use BOARD_CUSTOMIMAGES_PARTITION_LIST to include the required files in `system_image_dir`. TAG=agy CONV=5d08e900-4fb1-44ec-b4fb-1a3cc848cdd2
erjiaqing
force-pushed
the
510177847-p2.2
branch
from
November 17, 2026 16:08
87716cd to
3baa1b8
Compare
adelva1984
enabled auto-merge
November 17, 2026 18:12
adelva1984
disabled auto-merge
November 18, 2026 21:42
adelva1984
enabled auto-merge
November 18, 2026 21:42
adelva1984
disabled auto-merge
November 19, 2026 02:45
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, crosvm_acpi_table, crosvm_device_tree_overlay and
crosvm_file_backed_mapping only work with absolute paths.
This change modifies the behavior by not just proxying the values, but
also checking
system_image_dirwhen a relative path is passed. Thisshould be useful when using and sharing config files.
Bug: 544996625
Bug: 539399873
Bug: 510177847
Test: bazel test //cuttlefish/host/commands/assemble_cvd/...
TAG=agy
CONV=5d08e900-4fb1-44ec-b4fb-1a3cc848cdd2