[17krishna8]

The minPinLengthRPIDs entries are defined as fully qualified domain names, which RFC 1035 limits to 253 bytes in presentation format.

Longer strings are currently accepted while parsing and only rejected later, when storing the list fails because the serialized value exceeds the maximum value size of the persistent store, after the token permissions were already checked.

Reject such entries when parsing the parameters, so the request fails with CTAP1_ERR_INVALID_PARAMETER before anything else runs.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Code Review

This pull request introduces a maximum length validation of 253 bytes for RP IDs within SetMinPinLengthParams to prevent storing excessively large serialized values, accompanied by new unit tests. Feedback suggests optimizing this validation by performing the length check inside the mapping closure during parsing, which avoids unnecessary heap allocations and improves efficiency in memory-constrained environments.

[17krishna8]

The length check moved into the mapping closure: the request now fails with CTAP1_ERR_INVALID_PARAMETER as soon as an oversized entry is parsed, before the rest of the list is allocated.

[kaczmarczyck]

This is somewhat inconsistent with #805. There we introduce MAX_RP_ID_LENGTH instead of MAX_MIN_PIN_LENGTH_RP_ID_LENGTH with the same value. Also the other PR checks for empty sttrings, this one doesn't.

I think the changes here generally make sense. We might want to merge them into #805. Or we merge that, and then import and reuse the constant.

[coveralls]

Coverage is 97.37% — 17krishna8:fix/reject-long-min-pin-rp-ids into google:develop. No base build found for google:develop.

[17krishna8]

Thanks for the review! I aligned this PR with #805:

• The constant is now named MAX_RP_ID_LENGTH with the same value and doc comment.
• Empty entries are rejected as well, with a matching test.

Happy to fold these changes into #805 if that is easier for you. Otherwise, once #805 lands I will rebase this PR and import the constant from there instead of redefining it.