You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Handle bounding boxes in 2D ndimage warping - #117
ndimage_warp assumes three spatial dimensions when reshaping map offsets, allocating an explicit output box and computing map/output offsets. With 2D images, explicit bounding boxes cause broadcasting errors or add an unwanted axis.
Make those operations dimension-aware. Add 2D regressions and 3D controls with translated/cropped boxes, unequal strides, output scaling and threaded warping.
Validation: python -m pytest -q tests/warp_test.py tests/map_utils_test.py tests/flow_utils_test.py passes all 32 tests. Five new 2D regression cases fail on unchanged upstream; all five 3D controls already pass. Syntax parsing and git diff --check pass.
@mjanusz This PR is current with main and has no public failing checks; only the Google import/review gate remains. It adds the 2D ndimage bounding-box handling with focused coverage. Could you review the current head when convenient?
@mjanusz Refreshed onto current main. The branch was 1 commit behind and is now 0 behind and mergeable; head bfa6f38fc9fcd60ac727843f4ce54df1a862cfc3 is GitHub Verified. The focused 2D/3D ndimage bounding-box regression class passes 10/10 selected tests. git diff --check is clean; the repository-wide Pyink reformat signal also reproduces on current main, so I left unrelated formatting unchanged. CLA is green and Copybara is waiting for internal safe-review approval. Could you review the refreshed head when convenient?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ndimage_warpassumes three spatial dimensions when reshaping map offsets, allocating an explicit output box and computing map/output offsets. With 2D images, explicit bounding boxes cause broadcasting errors or add an unwanted axis.Make those operations dimension-aware. Add 2D regressions and 3D controls with translated/cropped boxes, unequal strides, output scaling and threaded warping.
Validation:
python -m pytest -q tests/warp_test.py tests/map_utils_test.py tests/flow_utils_test.pypasses all 32 tests. Five new 2D regression cases fail on unchanged upstream; all five 3D controls already pass. Syntax parsing andgit diff --checkpass.