Repository navigation
[bot] Merge master/d2065c26 into rel/dev - #1892
Merged
Merged
Conversation
CatalogDeclarativeMetric did not declare is_hidden_from_kda. The generated DeclarativeMetric gained the field when the API client was regenerated, but the SDK attrs class was not updated, and cattrs drops keys a class does not declare. So loading a metric layout from disk or the server lost the flag silently, and every SDK put sent the metric without it: a git deploy could never set it, and a load-then-put wiped a flag set in the UI. Declare the field on the metric class only; the other analytics classes share CatalogAnalyticsBase but their generated models have no such field. An unset field stays None and is not sent, so existing layouts and cassettes are unchanged. A round-trip test covers true, false and an absent key through disk and to_api(). jira: GDAI-2630 risk: low
fix(gooddata-sdk): keep isHiddenFromKda on declarative metrics
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1892 +/- ##
========================================
Coverage 85.09% 85.09%
========================================
Files 337 337
Lines 24331 24332 +1
========================================
+ Hits 20704 20705 +1
Misses 3627 3627 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to d2065c2 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/39609558402).