Skip to content

Tighten bats spies and make release create idempotent - #6

Merged
davidnewhall merged 1 commit into
mainfrom
pr3-copilot-followup
Aug 25, 2026
Merged

davidnewhall merged 1 commit into
mainfrom
pr3-copilot-followup

Conversation

@davidnewhall

@davidnewhall davidnewhall commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Record package_cloud argc and each argument separately, and add a fixture path with spaces so an unquoted push would fail the suite (#4).
  • Cover gem install --user-install when the CLI is missing from PATH, and assert sudo is not used.
  • Skip gh release create when the release already exists so a workflow re-run can still move floating tags (#5).

Left alone: the v[0-9]+.[0-9]+.[0-9]+ tag filter. That pattern already fired for v1.1.1.

Test plan

  • bats test (12 cases)
  • CI bats and shellcheck jobs on this PR

Made with Cursor

… on re-run.

The previous spy flattened arguments, so a quoting regression would still pass, and a second release job run would block floating tags.

Co-authored-by: Cursor <cursoragent@cursor.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves upload test precision and makes release workflow reruns idempotent.

Changes:

  • Records package_cloud arguments individually and tests paths containing spaces.
  • Tests user-local gem installation without sudo.
  • Skips release creation when the release already exists.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
test/upload.bats Strengthens upload and installation tests.
.github/workflows/release.yml Makes release creation safe to rerun.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@davidnewhall
davidnewhall merged commit e3bdce0 into main Aug 25, 2026
3 checks passed
@davidnewhall
davidnewhall deleted the pr3-copilot-followup branch August 25, 2026 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants