Repository navigation
Tighten bats spies and make release create idempotent - #6
Merged
Merged
Conversation
… on re-run. The previous spy flattened arguments, so a quoting regression would still pass, and a second release job run would block floating tags. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Pull request overview
Improves upload test precision and makes release workflow reruns idempotent.
Changes:
- Records
package_cloudarguments individually and tests paths containing spaces. - Tests user-local gem installation without
sudo. - Skips release creation when the release already exists.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test/upload.bats |
Strengthens upload and installation tests. |
.github/workflows/release.yml |
Makes release creation safe to rerun. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package_cloudargc and each argument separately, and add a fixture path with spaces so an unquotedpushwould fail the suite (#4).gem install --user-installwhen the CLI is missing fromPATH, and assertsudois not used.gh release createwhen the release already exists so a workflow re-run can still move floating tags (#5).Left alone: the
v[0-9]+.[0-9]+.[0-9]+tag filter. That pattern already fired forv1.1.1.Test plan
bats test(12 cases)batsandshellcheckjobs on this PRMade with Cursor