Repository navigation
Save new worker registration with its first heartbeat - #91
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pool node can try to clean up a worker while another node is still creating it. The constructor previously saved the worker before its first heartbeat, so cleanup could claim the newly visible worker and make
AddWorkerfail. Worker registration now saves both records in one Redis operation. Repeating that operation returns the same first heartbeat, so a delayed command cannot replace the timestamp the constructor is waiting for.The pool owns registration and cleanup. It checks that the pool, node, and original worker stream are still active before saving anything. A failed constructor destroys its stream before removing both registration records; if destruction fails or another node has claimed cleanup, it preserves the records that cleanup needs.
AddWorkeralso checks lifecycle state without holding the local lock needed for retirement. Callers keep the same inputs and result types, including the existing lifecycle errors.Stored record formats and public APIs are unchanged. Old and new pool nodes can share the same records, although an older node retains the original constructor race. Review
pool/worker_registration.go,Node.AddWorker, andnewWorkerfirst.