Repository navigation
tests: report errors from goroutines with t.Error, as go vet requires - #25
Open
louisabraham wants to merge 1 commit into
Open
louisabraham wants to merge 1 commit into
louisabraham wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go vet ./...reports four calls tot.Fatal/t.Fatalffrom a goroutine other than the test's:t.Fatalcallsruntime.Goexit, which only stops the goroutine that calls it. From another goroutine it does not stop the test, andtestingdocuments that it must not be called there. Each call is replaced witht.Error/t.Errorf, followed byreturnwhere the goroutine must stop.In
pool_test.go, the goroutine still closesdoneafter a failedStep. Before this change, a failure there skippedclose(done).Checked:
go vet ./...reports nothing, andgo test -race ./...passes.