Repository navigation
Compile SQLite with SQLITE_ENABLE_MATH_FUNCTIONS - #23
Open
louisabraham wants to merge 1 commit into
Open
louisabraham wants to merge 1 commit into
louisabraham wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
#define SQLITE_ENABLE_MATH_FUNCTIONS 1toc/sqlite_config.h.Without it,
sqrt(),pow(),floor(),ceil(),ln(),log10(),pi()and the rest of SQLite's math functions fail with "no such function". SQLite's own builds have them: per the compile-time options page, theconfigurescript adds the option on Unix unless--disable-mathis passed, and the WindowsMakefile.mscbuild includes it. So SQL written against thesqlite3shell or a system SQLite fails here.We hit this when moving a service from
zombiezen.com/go/sqlite(modernc, which has the math functions) to this package: SQL that already ran there stopped working.The change only adds functions. An application-defined function with the same name still takes precedence, because SQLite lets
sqlite3_create_functionoverload built-in functions.Tests
TestMathFunctionscheckssqrt,pow,floor,ceil,ln,log10andpi. It fails without the define.go test ./...passes.CHANGELOG.mdhas an entry under Unreleased / Changed.