Repository navigation
auth: do not panic on an action code this package does not decode - #22
Open
louisabraham wants to merge 1 commit into
Open
louisabraham wants to merge 1 commit into
louisabraham wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
newActionInfopanics on an action code it does not decode. It runs inside the authorizer callback, so the panic unwinds through SQLite's C stack and ends the process. A SQLite release that adds an action code would turn every statement that triggers it into a crash, even for an authorizer that would simply deny the action.This change removes the panic. An unknown code reaches the
AuthorizerwithAction,DatabaseandInnerMostTriggerset and the other fields empty, so the authorizer can deny it.ActionInfo.String()already handles this case (unknown action: …).Tests
TestUnknownActionDoesNotPanicdecodes action code 9999 throughnewActionInfo, exported to the tests inexport_test.go. It checksAction,DatabaseandString(). Before this change, the test panics.go test ./...passes.CHANGELOG.mdhas an entry under Unreleased / Fixed.Context: we run untrusted SQL behind an authorizer that denies every action it does not know, so a new action code must reach it.