Repository navigation
make MCTol work in adtest - #548
Merged
Merged
Conversation
pr0m1th3as
added a commit
that referenced
this pull request
Nov 13, 2026
The MCTol check takes a positive real scalar of type double or single, and an empty value only as double or single. The help text says so. Tests use assert_equal and cover NaN, cell, char, logical, integer and empty char tolerances.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the
MCToloption madeadteststop with'mctol' undefined, because theMonte Carlohelper was called with a variable name that does not exist. It was affected for every distribution, composite or fully specified. The helper is now called with the correct variable, so the p-value and critical value are computed by simulation.MCTolis also now required to be a real positive scalar.NaNandcomplexvalues used to pass the check, and a cell failed with an operator error instead of anadtesterror. They now all giveinvalid Monte Carlo Tolerance.BEFORE:
AFTER:
MATLAB: