Repository navigation
Conversation
- Replace the abandoned robloach/component-installer and oomphinc/composer-installers-extender (and with them kriswallsmith/assetic, symfony/process 3.4 with CVE-2024-51736 and composer/installers) via composer 'replace'; the extension only uses files directly from vendor/ - Drop components/jquery 4.0 (phpBB ships jQuery) and fortawesome/font-awesome 4.4 (phpBB ships Font Awesome 4.7, remove the @font-face override) - Require moment/moment directly (^2.30), eonasdan/bootstrap-datetimepicker ^4.17.49 - ext.php: check both the datetimepicker and moment files (the first check was overwritten) - Remove the outdated tracked composer.phar (Composer 1.10), update actions/checkout to v6 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014TpJhHt7ke8q3BnSZ8wGZf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #75 (this PR is based on its branch; after #75 is merged it can be retargeted to
master, the diff then only contains the commit below).Summary
Audit of the Composer dependencies (
composer outdated,composer audit,composer why) and what the extension actually uses fromvendor/:robloach/component-installer,oomphinc/composer-installers-extendercomponents/dir the extension never usesreplaceincomposer.json, not installedkriswallsmith/assetic,composer/installerssymfony/process 3.4.47composer auditis cleancomponents/jquery 4.0.0replacedfortawesome/font-awesome 4.4.0FontAwesome@font-face@font-faceremoved, the glyph codes inhookup.cssare the same in 4.7eonasdan/bootstrap-datetimepicker >=4.17^4.17.49(latest of the 4.x line)moment/moment(transitive)moment.min.js)^2.30(2.31.0 installed)Installed packages go from 9 to the 2 that are used.
Other changes:
ext.php: the dependency check for the datetimepicker was overwritten by the moment check (same array key); both files are checked now. Removed the checks for packages that are no longer required.composer.phar(Composer 1.10, unused since Travis was removed)actions/checkoutv4 → v6 intests-3.2.yml(Node 20 deprecation)Not changed
eonasdan/bootstrap-datetimepicker4.17.49 is the last release of its line (Bootstrap 3 based, the project has moved on to Tempus Dominus).momentis in maintenance mode as well. Replacing the picker with Tempus Dominus 6 would be a rewrite ofcal-settings.jsand the picker CSS (needs Popper and Bootstrap 5 styling, is not available on Packagist), so it is left for a separate change.Test plan
composer installfrom scratch: only the two packages,composer auditfinds nothingdeloads, the chevron/clock icons render with phpBB's Font Awesome 4.7, no JS errorsGenerated by Claude Code