Repository navigation
Conversation
- Declare the $user property in the listener (dynamic properties are deprecated in PHP 8.2) - Tests: use @before instead of setUp() (PHPUnit 4 - 9 compatible), add compat trait for assertContains - phpunit.xml.dist: drop options removed in newer PHPUnit - Version check now points to the phpBB.com customisation database (PR #16) - Exclude CI and dev files from export archives (PR #15) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AXek2CuiLeFBsgjo8BdEU1
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AXek2CuiLeFBsgjo8BdEU1
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AXek2CuiLeFBsgjo8BdEU1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The extension's runtime code only uses stable events (
core.posting_modify_cannot_edit_conditions,core.viewtopic_modify_post_action_conditions,core.permissions,core.modify_posting_auth) plusauth/user, so it already works on phpBB 3.1, 3.2 and 3.3. This PR fixes the remaining issues and makes the test suite run on PHPUnit 4 through 9.event/listener.php: declare the$userproperty (dynamic properties are deprecated as of PHP 8.2).tests/event/listener_base.php: replace thesetUp()override with a@beforemethod. phpBB 3.3 (PHPUnit 9) requiressetUp(): void, which is a syntax error on PHP < 7.1 used by 3.1/3.2.tests/compat.php+tests/functional/install_test.php: add anassertTextContainshelper, since PHPUnit 9 no longer accepts strings inassertContains. Same approach as the hookup extension.phpunit.xml.dist: dropsyntaxCheckand thephpVersionattributes, which newer PHPUnit versions reject.composer.json: version check now points to the phpBB.com extension database (from Update version check host and directory in composer.json #16, the oldphpbb.gn36.deURL returns a 404)..gitattributes: add.github/to the export-ignore list (in the spirit of PPSSE fix & exclude irrelevant files #15) and markcomposer.pharas binary to stop phantom line-ending changes.README.md: mention 3.1, 3.2 and 3.3.PHP requirement stays at
>=5.3.3. The tests were not run (no phpBB checkout was available); all PHP files passphp -l. The CI matrix in.travis.ymland.github/workflows/tests.ymlis unchanged.Closes #16
Generated by Claude Code