Repository navigation
ci: drop the Dependabot npm branch separator, it didn't fix the update - #42
Merged
Merged
Conversation
Signed-off-by: Nicolai Ehrhardt <245527909+predictor2718@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #41.
Why
#41 guessed that Dependabot's npm update failed because
.githubbecame a branch path component. That guess was wrong. The next run withseparator: "-"failed the same way:The npm install and the lockfile update work. Dependabot's service rejects the pull request itself. The separator doesn't help, and its comment gives a wrong reason, so it goes. The open question is tracked in an issue of its own.
How to test
.github/dependabot.ymlis the same as after #40.