Repository navigation
Demo: glsec findings as code scanning annotations - #1
Closed
predictor2718 wants to merge 1 commit into
Closed
predictor2718 wants to merge 1 commit into
predictor2718 wants to merge 1 commit into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| - set -x | ||
| - curl -sSL https://get.example.com/install.sh | sh | ||
| - 'curl -H "Authorization: Bearer $DEPLOY_TOKEN" "https://hooks.example.com/deploy?branch=$CI_COMMIT_REF_NAME"' | ||
| - ssh -o StrictHostKeyChecking=no deploy@prod.example.com ./release.sh |
| - if: $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH | ||
| include: | ||
| - project: platform/ci-templates | ||
| ref: main |
| - template: Security/Secret-Detection.gitlab-ci.yml | ||
|
|
||
| variables: | ||
| DOCKER_AUTH_CONFIG: '{"auths":{"registry.example.com":{"auth":"ZGVwbG95OnMzY3IzdA=="}}}' |
|
|
||
| build: | ||
| stage: build | ||
| image: node:latest |
| expire_in: 1 week | ||
| paths: | ||
| - dist/ | ||
| - .env |
|
|
||
| secret_detection: | ||
| rules: | ||
| - when: never |
| image: node:22.11.0 | ||
| script: | ||
| - npm ci | ||
| - echo Running tests for $CI_COMMIT_REF_NAME |
| stage: build | ||
| image: docker:27.3.1 | ||
| services: | ||
| - docker:27.3.1-dind |
| stage: build | ||
| image: node:latest | ||
| script: | ||
| - npm install |
| @@ -1,12 +1,62 @@ | |||
| # The same service before the changes in the demo pull request: no findings. | |||
| # The pipeline of a small Node.js service, with the kind of security mistakes | |||
This was referenced Oct 26, 2026
Signed-off-by: Nicolai Ehrhardt <245527909+predictor2718@users.noreply.github.com>
predictor2718
force-pushed
the
demo/findings
branch
from
October 26, 2026 17:31
7d3bebf to
917aeda
Compare
Member
Author
|
Replaced by a new demo pull request: the review comments on this one were written before glsec 1.24.1 added rule titles to its SARIF, and GitHub doesn't update them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kept open on purpose as a demo, not meant to be merged.
mainholds a clean pipeline. This pull request turnsbad-pipeline.ymlinto the example from glsec.github.io/reports, and the glsec workflow uploads its SARIF report to code scanning. The findings show up as annotations on the changed lines under Files changed, and as alerts in the code scanning results of this pull request.