Repository navigation
fix: flush the closing reply (464/ERROR) before closing the socket - #59
Merged
Merged
Conversation
gitraphha
approved these changes
Sep 22, 2026
ArchCipher
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: flush the closing reply (464 / ERROR) before closing the socket. When the server closed a connection itself (wrong password during registration or QUIT), the closing reply was queued in the client's write buffer, but the socket was closed in the same poll() iteration, before poll() ever reported POLLOUT. So the client ended up not receiving 464 for a wrong password or "ERROR :Closing link" for QUIT. It just got eof. I wasn't sure whether this would be considered a fail, but from what I've been seeing and reading, it is very likely that it would. It was a very small fix, so I thought it made sense to add it and not risk it..