Skip to content

fix: multiple polls for bonus and strict fcntl - #57

Merged
numorb merged 4 commits into
mainfrom
fix/multiple-polls-fcntl
Sep 22, 2026
Merged

numorb merged 4 commits into
mainfrom
fix/multiple-polls-fcntl

Conversation

@numorb

@numorb numorb commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator

Fix to leave just one single poll() call to adhere to the subject's mandatory requirement. Same with make fcntl implementation exactly as it is allowed to be used. Minimal changes.

Two lines were uncommented as no longer in use, to keep track of what was there just in case.

gitraphha
gitraphha previously approved these changes Sep 22, 2026
Comment thread srcs/server/Server.cpp Outdated
Comment thread srcs/server/Server.cpp
@ArchCipher

Copy link
Copy Markdown
Collaborator

Other than fixes mentioned above I am okay.

Screenshot 2026-09-22 at 11 22 22

numorb and others added 4 commits September 22, 2026 12:14
Co-authored-by: Kiruthika Murugananthan <kiruthika_m@protonmail.com>
Co-authored-by: Kiruthika Murugananthan <kiruthika_m@protonmail.com>
@numorb
numorb force-pushed the fix/multiple-polls-fcntl branch from 714f179 to 8c998db Compare September 22, 2026 10:14

@gitraphha gitraphha left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, now we have double-safety. Better than double close 😅

@numorb
numorb merged commit b72ca80 into main Sep 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants