Repository navigation
Rebase on upstream 2.3.1 and switch from Puppet to OpenVox - #377
Closed
marc-makandra wants to merge 10 commits into
Closed
marc-makandra wants to merge 10 commits into
marc-makandra wants to merge 10 commits into
Conversation
The puppet gem is dead and won't be updated anymore. And it doesn't work on Ruby 4.
PSON.parser= removed PSON::Parser whenever `const_defined? :Parser` was true. That check also finds a top-level ::Parser, e.g. from the `parser` gem that RuboCop and tapioca load, and remove_const then raises "constant PSON::Parser not defined" while loading octocatalog-diff.
marc-makandra
marked this pull request as draft
October 31, 2026 02:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream github/octocatalog-diff is unmaintained (#335, #347 unanswered), and the puppet gem doesn't work on Ruby 4 (facter). This branch replaces our master and Felix's octocatalog_2.1.0_makandra:
Felix's Puppet 6, HashDiff and vendor commits are obsolete with upstream 2.3.1; #261 and the Ruby 3.2 fix are covered by #302.
Tested: ops_tools on Ruby 4.0.6 resolves and loads it (bundle install, tapioca gems --all). The fork's own rspec suite doesn't run on Ruby 4 (rspec 3.4, rubocop 0.49) – not touched here.