Conversation
Cargo unifies features across the dependency graph, so the hard-coded reqwest/native-tls feature flipped reqwest's TlsBackend::default() to native-tls for every reqwest client in a consumer's whole binary, not just the SDK's request-handler transport. Introduce rustls (default, aws-lc-rs via reqwest's rustls feature) and native-tls (opt-in) features instead. Fixes github#1805
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1805. Supersedes the stale draft #1851, which targets reqwest 0.12 and now conflicts with
main. This version also uses aws-lc-rs, which answers the review question on #1851 about standardizing on one crypto stack with the runtime.rust/Cargo.tomlhard-codesnative-tlson the request-handler transport'sreqwestandtokio-tungstenitedependencies. This does more than link OpenSSL. Cargo unifies features across the whole dependency graph, and reqwest 0.13'sTlsBackend::default()picksNativeTlswhenever__native-tlsis enabled. So simply depending ongithub-copilot-sdkswitches everyreqwest::Clientin the consumer's binary from rustls to OpenSSL, including clients that have nothing to do with the SDK. We hit this in a large workspace: bumping the SDK silently moved ~450 unrelated HTTP clients to OpenSSL and broke TLS against a test CA. Consumers have no way to opt out today.Change
rustlsfeature, on by default:reqwest/rustls(the aws-lc-rs provider, same as the runtime) andtokio-tungstenite/rustls-tls-native-roots. No system OpenSSL is needed, so musl and static targets build.native-tlsfeature: the previous platform-native stack.reqwestandtokio-tungstenitedependencies no longer hard-code a TLS feature. The transport code is already backend-agnostic, so no source changes were needed.default-features = falsemust enable one of them if they register arequest_handlerthat forwards to HTTPS/WSS.The build-time CLI download (
[build-dependencies]ureq/native-tls) is unchanged. It is a separate build-script graph and does not affect the consumer's runtime features.Validation
Built inside a consumer workspace with
default-features = false, features = ["runtime", "rustls"].cargo tree -i hyper-tlsno longer reaches reqwest 0.13, and the consumer crates compile.