Repository navigation
Fix dry-run crash, check re-runs, cross-app runs and stuck checks - #1117
Open
alexggordon wants to merge 2 commits into
Open
alexggordon wants to merge 2 commits into
alexggordon wants to merge 2 commits into
Conversation
alexggordon
commented
Oct 22, 2026
alexggordon
commented
- Repository.sync(): await side-effect promises in both modes and report failures through handleSideEffectError(). A failed default-branch creation on an empty repo no longer causes an unhandled rejection in NOP mode, and in apply mode no longer triggers force_create.
- check_suite.rerequested: remove the duplicate handlers that called createCheckRun() without a head_sha (422) and route re-runs through the check_suite.requested handler. Fixes check_suite.rerequested handler fails with "head_sha wasn't supplied" when re-running dry-run check via GitHub UI #1015.
- check_run.created: skip check runs created by another app, using the app ID captured in info().
- Paginate pulls.listFiles (per_page 100, 3,000-file API cap) so files after the first 30 are inspected. Fixes Dry run only inspects the first 30 changed files (pulls.listFiles is not paginated) #1080.
- handleResults(): always complete the check run when posting the PR comment fails, and note the failure in the check output. Refs commentmessage can be too big and fail #245, Check run stuck for PR in admin repository #414.
- pull_request.opened/reopened: read head.ref instead of the non-existent head_branch. Behavior change: PRs whose head is the default branch no longer get a validator check.
- Repository.sync(): await side-effect promises in both modes and report failures through handleSideEffectError(). A failed default-branch creation on an empty repo no longer causes an unhandled rejection in NOP mode, and in apply mode no longer triggers force_create. - check_suite.rerequested: remove the duplicate handlers that called createCheckRun() without a head_sha (422) and route re-runs through the check_suite.requested handler. Fixes github-community-projects#1015. - check_run.created: skip check runs created by another app, using the app ID captured in info(). - Paginate pulls.listFiles (per_page 100, 3,000-file API cap) so files after the first 30 are inspected. Fixes github-community-projects#1080. - handleResults(): always complete the check run when posting the PR comment fails, and note the failure in the check output. Refs github-community-projects#245, github-community-projects#414. - pull_request.opened/reopened: read head.ref instead of the non-existent head_branch. Behavior change: PRs whose head is the default branch no longer get a validator check.
alexggordon
force-pushed
the
alexggordon/fix-safe-settings-defects
branch
from
October 23, 2026 21:49
6b06dc4 to
f30a86e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.