Repository navigation
Add an upstream cluster profile for client-rust's own integration suites - #56
Merged
Merged
Conversation
…uites client-rust's integration suites (`make integration-test-txn` / `-raw`) need the cluster its CI runs: three TiKV stores under `tiup playground` with its config/tikv.toml and config/pd.toml, which are api-v2 with TTL and gzip. The harness's `single` and `3store` profiles deliberately are not (cluster/tikv.toml says why), so until now running those suites locally meant tiup. - cluster/docker-compose-upstream.yml: the 3-store compose shape with the same pinned images, host networking and broker-assigned ports, mounting client-rust's two config files from $CLIENT_RUST_CONFIG (default the sibling ../client-rust/config; point it at the checkout under test). - cluster-broker: the `upstream` profile (3 stores). - make cluster-up-upstream / cluster-down-upstream: lease manual-upstream on slot 0, like the other two profiles. Verified: a broker lease came up with all three stores Up and TiKV reporting api-version 2, enable-ttl, gzip and the CI split thresholds; client-rust PR #558's txn (55) and raw (10) suites passed against it. `make check` green.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8e2da1c1c0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: client-rust's integration suites (
make integration-test-txn/-rawin client-rust) need the cluster its CI runs: three TiKV stores undertiup playgroundwith client-rust'sconfig/tikv.tomlandconfig/pd.toml, which are api-v2 with TTL and gzip. The harness'ssingleand3storeprofiles deliberately are not (cluster/tikv.tomlsays why), so verifying a client-rust PR against a live cluster meant installing tiup.What:
cluster/docker-compose-upstream.yml: the 3-store compose shape with the same pinned images, host networking and broker-assigned ports. It mounts client-rust's two config files from$CLIENT_RUST_CONFIG(default: the sibling../client-rust/config; point it at the checkout under test).scripts/cluster-broker: theupstreamprofile (3 stores).make cluster-up-upstream/cluster-down-upstream: leasemanual-upstreamon slot 0, like the other two profiles.Usage for a PR checkout:
Verification: a broker lease came up with all three stores Up, and TiKV's
/configreportedapi-version = 2,enable-ttl = true, gzip and the CI split thresholds. tikv/client-rust#558's txn (55/55) and raw (10/10) suites passed against it.make checkis green.Note, not fixed here:
broker-testbinds real ports (slots 1–2, e.g. 32000), so it fails while a broker lease holds slot 1, and for about a minute after one is released (TIME_WAIT). That is pre-existing; this PR doesn't change it.