Skip to content

docs(core): Correct TransactionData::iter docs about unsampled transactions #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szokeasaurusrex merged 2 commits into from
Oct 13, 2026
Merged

docs(core): Correct TransactionData::iter docs about unsampled transactions #1351

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a5958b
docs(core): Correct TransactionData::iter docs about unsampled transa…
sentry-junior[bot] Oct 13, 2026
bd95c60
docs(core): Only mention the no-client case in TransactionData::iter …
sentry-junior[bot] Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions sentry-core/src/performance/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,9 +753,8 @@ impl<'a> TransactionData<'a> {
/// Iterate over the [data attributes](protocol::TraceContext::data)
/// associated with this [transaction][protocol::Transaction].
///
/// If the transaction is not sampled for sending,
/// the metadata will not be populated at all,
/// so the produced iterator is empty.
/// If no client was bound when the transaction was started,
/// the produced iterator is empty.
pub fn iter(&self) -> Box<dyn Iterator<Item = (&String, &protocol::Value)> + '_> {
if self.0.transaction.is_some() {
Box::new(self.0.context.data.iter())
Expand Down
Loading