Skip to content

refactor(ios): Use internal Cocoa serialization - #6917

Merged
philprime merged 4 commits into
mainfrom
refactor/internal-cocoa-serialization
Oct 22, 2026
Merged

philprime merged 4 commits into
mainfrom
refactor/internal-cocoa-serialization

Conversation

@philprime

@philprime philprime commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Route native scope and debug-image serialization through Cocoa's internal serializer instead of public model serialize() methods. Preserve the dictionaries returned to JavaScript.

💡 Motivation and Context

Prepares for Cocoa's v10-only serialization API removal, while allowing migration on v9.

Dependency: Requires #6925 to be merged first.

💚 How did you test it?

Local yarn build, yarn test, yarn lint, and yarn circularDepCheck passed. Native integration validation is delegated to CI.

📝 Checklist

  • I added tests to verify changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.
  • No breaking changes.

🔮 Next steps

Release the Cocoa replacement APIs, update the native dependency through the established workflow, and confirm native CI before merging.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


  • refactor(ios): Use internal Cocoa serialization by philprime in #6917
  • chore(deps): update CLI to v3.8.1 by github-actions in #6924
  • chore(deps): update Cocoa SDK to v9.31.0 by github-actions in #6925
  • fix(tracing): Respect enableHTTPTimings and stop leaking HTTP timing listeners by antonis in #6912
  • fix(core): Stop wrapping RNSentry in TurboModuleContext by default by alwx in #6921
  • chore(deps): bump launch-editor from 2.14.1 to 2.14.2 by dependabot in #6922
  • ci: Fix Linux jobs on Ubuntu 26.04 runners by antonis in #6920
  • fix(core): Match Sentry package paths with Windows separators in Metro resolvers by alwx in #6915
  • chore(e2e): Update Expo sample to SDK 58 by antonis in #6914
  • chore(e2e): Bump E2E tests to React Native 0.88.0 by antonis in #6899
  • fix(ios): Find .xcode.env in the debug symbols phase under SwiftPM by alwx in #6911
  • chore(deps): update React Native to v0.88.0 by github-actions in #6903
  • chore(deps): bump getsentry/craft from 2.34.1 to 2.35.0 by dependabot in #6906
  • chore(deps): bump actions/create-github-app-token from 3.2.0 to 3.3.0 by dependabot in #6908
  • chore(deps): bump getsentry/craft/.github/workflows/changelog-preview.yml from 2.33.1 to 2.35.0 by dependabot in #6907
  • chore(sample): Bump React Native sample to 0.88.0 by antonis in #6910
  • chore(deps): bump actions/setup-java from 6.0.1 to 6.1.0 by dependabot in #6909
  • chore(deps): bump the codeql-action group with 3 updates by dependabot in #6905
  • chore(deps): update Sentry Android Gradle Plugin to v6.24.0 by github-actions in #6902
  • chore(deps): bump @appium/support from 7.0.6 to 7.2.8 by dependabot in #6897
  • ci(e2e): Remove app metrics job and performance-tests by antonis in #6896

🤖 This preview updates automatically when you update the PR.

@linear-code

linear-code Bot commented Oct 20, 2026

Copy link
Copy Markdown

COCOA-2088

@philprime philprime self-assigned this Oct 20, 2026
@philprime philprime added the ready-to-merge Triggers the full CI test suite label Oct 20, 2026
Comment thread packages/core/ios/RNSentry.mm
@philprime
philprime marked this pull request as ready for review October 20, 2026 14:03
@sentry

sentry Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
Sentry RN io.sentry.reactnative.sample 8.31.0 (111) Release

⚙️ sentry-react-native Build Distribution Settings

@alwx

alwx commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

@philprime seems like the sentry-cocoa needs to be bumped first

Comment thread packages/core/ios/Swift/RNSentryInternal.swift
@sentry

sentry Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Size Analysis

❌ 1 Failed Size Check

iOS Builds

Name Configuration Version Download Size Install Size
sentryreactnativesample (iOS)
io.sentry.reactnative.sample
Release 8.31.0 (116) 11.7 MB (+19.7 KB) 36.1 MB (+53.2 KB)
1 Failed Check

io.sentry.reactnative.sample | Release (iOS)

  • Install Size (Absolute Diff) > 50.0 KB — Main App

1 Analyzed

Android Builds

Name Configuration Version Download Size Uncompressed Size
Sentry RN (Android)
io.sentry.reactnative.sample
Release 8.31.0 (111) 15.0 MB (-2 B) 41.2 MB (0 B)

Configure sentry-react-native status check rules

@antonis antonis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Also #6925 is now merged

@philprime
philprime enabled auto-merge (squash) October 22, 2026 08:24
@philprime
philprime merged commit e5d0b91 into main Oct 22, 2026
46 of 76 checks passed
@philprime
philprime deleted the refactor/internal-cocoa-serialization branch October 22, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Triggers the full CI test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants