Repository navigation
Conversation
Do not merge. Adds a ~480 KB incompressible PNG to the RN sample app to check that the Sentry Size Analysis status check fails and posts a PR comment when the 50 KB threshold is exceeded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
1 similar comment
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
Size Analysis❌ 4 Failed Size ChecksiOS Builds
Android Builds
4 Failed Checks
|
📲 Install BuildsAndroid
|
Contributor
Author
|
Verification done: Size Analysis check failed (4 rules > 50 KB) and posted a PR comment as expected. Closing without merging. |
7 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Do not merge. Throwaway PR to verify the Sentry Size Analysis threshold config.
📢 Type of change
📜 Description
Adds a ~480 KB incompressible noise PNG (
samples/react-native/src/assets/size-analysis-test.png) and renders it in the sample app's Playground tab, so Metro bundles it into both the iOS and Android release builds uploaded bysize-analysis.yml.💡 Motivation and Context
Size Analysis status check and PR comment rules (absolute diff > 50 KB) were configured for the
sentry-react-nativeproject. This PR intentionally exceeds the threshold to confirm:Size Analysischeck from Sentry fails (instead ofneutral/success), andThis is a prerequisite for replacing the
binarySizeTestin themetricsjob (#6890).💚 How did you test it?
CI only — the
ready-to-mergelabel triggers the Size Analysis workflow.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Close without merging once the check result is verified.
🤖 Generated with Claude Code