Repository navigation
ref(android): [Nav3 Lifecycle 2] Add lease-aware NavScopes facade - #6304
Merged
0xadam-brown merged 1 commit intoOct 22, 2026
Merged
0xadam-brown merged 1 commit into
0xadam-brown merged 1 commit into
Conversation
This was referenced Oct 20, 2026
📲 Install BuildsAndroid
|
This was referenced Oct 20, 2026
0xadam-brown
marked this pull request as ready for review
October 20, 2026 15:30
0xadam-brown
requested review from
adinauer,
markushi,
romtsn and
runningcode
as code owners
October 20, 2026 15:30
0xadam-brown
force-pushed
the
feat/part-2-sentry-nav-effect-lifecycle
branch
from
October 21, 2026 11:27
5c8e9cf to
d4b69f1
Compare
0xadam-brown
force-pushed
the
feat/part-1-sentry-nav-effect-lifecycle
branch
from
October 21, 2026 11:27
8292382 to
a010c9e
Compare
Base automatically changed from
feat/part-1-sentry-nav-effect-lifecycle
to
feat/sentry-nav-effect-lifecycle
October 22, 2026 07:49
0xadam-brown
force-pushed
the
feat/part-2-sentry-nav-effect-lifecycle
branch
from
October 22, 2026 08:25
3eac685 to
6d8b5ae
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6d8b5ae. Configure here.
Stage navigation scope state for inactive roots and publish it when the root acquires the lifecycle lease. Refs JAVA-274
0xadam-brown
force-pushed
the
feat/part-2-sentry-nav-effect-lifecycle
branch
from
October 22, 2026 10:11
6d8b5ae to
ebddd61
Compare
0xadam-brown
merged commit Oct 22, 2026
b67f3bf
into
feat/sentry-nav-effect-lifecycle
27 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR Stack (Nav3 Lifecycle)
📜 Description
Add a lease-aware
NavScopesfaçade that lets us swizzle nav data writes and reads between:IScope, vsStagedNavDataobject, specific to eachNavScopesinstance.See the NavScopes KDoc for (lots) more info, including a helpful diagram of how lease handoff works.
💡 Motivation and Context
Multiple active navigation roots write to the same Sentry scope. Staging slot-based state prevents an inactive root from overwriting the currently selected root while preserving its latest state for later restoration.
addresses: JAVA-785
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
The next PR wires this scope layer into
SentryNavEffectand enables the user-facing behavior.#skip-changelog