Repository navigation
Conversation
…n ACP diagnostics A system notice (child completion, wait resumption) that reaches a thread with an active provider turn now goes into the durable thread queue and is delivered at the turn boundary, instead of taking the live-steer path that cancels the running command. Human steers are unchanged. With diagnostic events hidden, ordinary ACP provider/unhandled events are no longer stored. Provider errors and terminal tool events are still stored. Fixes the false user-rejection stop on ACP providers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Thanks @timigod for the PR. This repo approves new contributors before it reviews their PRs, so this PR now closes on its own. That is expected. Join the #contributors channel in Discord (https://discord.gg/kvBU6tJhcJ), post a link to this PR, and explain what it changes and why. A maintainer then adds you to the allow list and can reopen the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5617
What changed
provider/unhandledevents are no longer stored. Provider errors and terminal tool events (completed, failed, cancelled) are still stored.Tests
apps/server/test/threads/thread-send-dispatch.test.ts) and "can omit unhandled provider diagnostics without shifting stored sequences" (packages/db/test/data/events.test.ts).@bb/serversuite on075826d6and on this branch, same environment: 3,502 passed, 3 failed, 1 skipped in both. The same three test files fail on075826d6: the machine-install HOME cases, the marketplace committer-date case, and a missing plugin-authoring fixture.@bb/servertypecheck passes.Investigated, implemented and verified end to end by Timi's coding agents: gpt-6.1-sol at high reasoning level, coordinated by Claude Opus 5.5 at max thinking level.
🤖 Generated with Claude Code