You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: use consistent 40px dimensions for dynamic content button - #3782
No actionable comments were generated in the recent review.
Walkthrough
Styles changed for dynamic-content, image-upload, and link controls. The dynamic-content button and image-upload control now use 40px sizing. Link-control styles no longer set fixed input heights or a negative top margin. The link input width calculation also changed.
Changes: Editor control styling
Layer / File(s)
Summary
Adjust control sizing and spacing src/components/dynamic-content-control/editor.scss, src/components/image-control2/editor.scss, src/components/link-control/editor.scss
The dynamic-content button and image-upload control now use 40px sizing. The link input width calculation changed from calc(100% - 32px) to calc(100% - 42px). Fixed input heights and a nested input’s negative top margin were removed.
gambitph/Stackable#3756: This PR changes nested input height and margin rules in the same link-control stylesheet.
Merge Risk: Minimal · up to 5a38d
This is an editor-only styling update that aligns the Dynamic Content button and related controls with the new 40px field height. No merge-blocking risk was found. The author's requested QA pass over the affected editor locations is the appropriate check.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title names the main change: the dynamic content button now uses consistent 40px dimensions. The raw summary confirms the button's width and height changed from 30px to 40px, and the linked object…
Linked Issues check
Issue #3780 requires the Dynamic Content button to match the new 40px input height and requires other fields that use the button to match. At head 5a38d75, .stk-dynamic-content-control__button in sr…
Out of Scope Changes check
All changed hunks are style changes in the three editor.scss files that render the Dynamic Content button and its adjacent controls. The button size, icon size, .ugb-image-upload height, and link-co…
Full details: Title check
Explanation
The title names the main change: the dynamic content button now uses consistent 40px dimensions. The raw summary confirms the button's width and height changed from 30px to 40px, and the linked objectives describe the same resize to match the 40px input fields. The title's 'fix:' prefix matches the linked issue #3780. The title does not cover the related height and width changes to the image upload and link control styles, which is acceptable.
Full details: Linked Issues check
Explanation
Issue #3780 requires the Dynamic Content button to match the new 40px input height and requires other fields that use the button to match. At head 5a38d75, .stk-dynamic-content-control__button in src/components/dynamic-content-control/editor.scss sets width, max-width, and height to 40px. The database icon is enlarged from 14×16px to 18×20px to stay centered. The explicit 30px height and 30px !important width in the image-control block are removed, so the button uses the 40px rule. src/components/image-control2/editor.scss sets .ugb-image-upload to 40px height. src/components/link-control/editor.scss removes the 30px height and adjusts the input width to calc(100% - 42px) for the resized button. Text, range, link, and image fields share this button class, so they inherit the new size. The change from the previous reviewed head only adds the removal of the image-control fixed sizes and icon resize, which supports the requirement. Automated tests were not part of the requirement. Residual uncertainty: the diff hunk does not show the full selector context of the removed image-control block, so the rendered result was not verified.
Full details: Out of Scope Changes check
Explanation
All changed hunks are style changes in the three editor.scss files that render the Dynamic Content button and its adjacent controls. The button size, icon size, .ugb-image-upload height, and link-control input width and height changes all serve the 40px sizing objective of #3780. No unrelated file or behavior change appears in the reviewed diff.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: b77d1764-3600-4c65-acf9-407041ec1eba
Commits
Reviewing files that changed from the base of the PR and between bf3a7e0 and 5a38d75.
Files selected for processing: 1
src/components/link-control/editor.scss
Files skipped from review as they are similar to previous changes: 1
src/components/link-control/editor.scss
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.
@malalacharm For QA visual check of the Dynamic Content button sizing in this PR (fixes #3780).
Please check that the Dynamic Content button (the small database icon next to the field) is 40px tall, lines up with the control beside it, and is not clipped, overlapping, or overflowing. Please check each location both before and after a dynamic field is assigned. After it is assigned, the field becomes a disabled 40px input and the button should stay pressed and still aligned. The icon inside the button should also look centered and not cut off.
These are all the editor locations in the free plugin where this button is used.
1. Text fields
In the inspector Style tab, open the typography panel and check the Content field (this field is multiline in Text and Timeline):
Table of Contents — Style > Title > Content (turn Title on)
Posts — Style > Read More Link > Content (turn Read More Link on)
Countdown — Style > Expired Message > Content (set the expiration action to show the expired message)
Heading, Text, Button, and Subtitle are also used as inner blocks inside blocks like Hero, Feature, and Card. Please check at least one inner block of each type.
Also check these other text fields (not typography Content):
Progress Circle — Style > Progress Circle > Progress
Only the Progress slider uses the Dynamic Content button. Maximum Progress and other sliders do not.
3. Link fields
Check Link / URL. The field width was adjusted so the reset button should still be visible and aligned.
Style > Link > Link / URL:
Button
Icon Button
Advanced > Link > Link / URL:
Icon (turn the Link toggle on if it is off)
Image — also check Link Title here
Advanced > Link > Link / URL and Link Title:
Card, Column, Call to Action, Notification, Icon Box, Image Box, Testimonial, Team Member, Pricing Box
4. Image fields
The Dynamic Content button sits on the image control, and the Upload / Replace button is also now 40px tall.
Image — Style > Image > Select Image
Card — Style > Image > Select Image
Background (turn Background on) — Style > Background > Background Image or Video, and Background Video Thumbnail (after a video is selected). Check this on desktop, tablet, and mobile, because this control changes with the responsive view.
Container Background (turn Container on) — Style > Container Background > Background Image or Video, and Background Video Thumbnail, also on desktop, tablet, and mobile. This appears on: Blockquote, Call to Action, Card, Column, Countdown, Feature, Hero, Icon Box, Notification, Posts, Pricing Box, Team Member, Testimonial.
Many other blocks also have Style > Background. Please spot-check a few of those too (for example Heading or Columns) once Background is enabled.
Note: Video Popup > Popup Option #1: Upload Video has no Dynamic Content button, and that is expected. Please still confirm the Upload / Replace button is 40px tall there.
What “good” looks like
The button height matches the 40px field height
The button is vertically aligned with the field
Nothing is clipped or overlapping, including the database icon
After a dynamic value is set, the disabled field and pressed button still line up
On Link / URL, the reset button is still visible
On image controls, the database button stays correctly placed on the preview (top right) and does not cover or get covered by the Upload / Replace button
This is editor-only. The button is hidden in the Customizer widgets editor, which is expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3780
Summary by CodeRabbit