You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
refactor(site): use published shared UI controls - #99
The landing site duplicated command-copy and theme-toggle controls already suitable for the shared UI library. Use the published upstream controls, remove the local implementations, and keep application-level interaction tests for copy and theme behavior.
Use explicit Tailwind application and library sources so dependency internals are not scanned. Preserve the site's content, layout, and development host configuration.
Contract: docs/changes/0046-adopt-upstream-ui-controls.md and docs/specs/architecture/index.md. This completes 0046. The exact upstream preview 0.0.0-a481115 is pinned in the dependency manifest and lockfile; it includes the merged packaging and component contributions. Move the pin to a stable release once one includes these changes.
Test plan
Install from the frozen published dependency lockfile without a local package link.
Run the unified root/site quality check with 100% required coverage and both builds passing.
Verify the final published controls in Chromium: multiline clipboard content, accessible feedback, both theme directions, keyboard use, and narrow-screen layout.
Confirm no browser console errors and no chart-selector CSS warnings.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The test leaves a process-wide fake clipboard installed because cleanup does not restore it, creating order-dependent behavior and potentially masking the fallback path.
This pull request replaces the site's duplicated command-copy and theme-toggle controls with the published @fx/ui components while preserving the existing layout, content, styling, and development configuration.
Changes:
Uses the pinned upstream CommandBlock, ThemeToggle, and ThemeProvider components.
Removes the local control implementations and redundant component tests.
Adds application-level interaction coverage for copy and theme behavior.
Restricts Tailwind scanning to explicit application and library sources.
Updates dependency locks and records change 0046 as complete.
This pull request requires changes.
File
Description
site/test/components.test.tsx
Removes tests for the deleted local controls.
site/test/application.test.tsx
Adds application-level copy and theme interaction tests.
site/src/index.css
Configures explicit Tailwind sources for site and library code.
site/src/components/ThemeToggle.tsx
Removes the local theme-toggle implementation.
site/src/components/CommandBlock.tsx
Removes the local command-copy implementation.
site/src/App.tsx
Imports and renders the shared controls from @fx/ui.
site/package.json
Pins the published @fx/ui preview dependency.
site/bun.lock
Locks the updated UI package and dependency metadata.
docs/index.yml
Registers change 0046 as complete.
docs/index.md
Adds change 0046 to the change history index.
docs/changes/0046-adopt-upstream-ui-controls.md
Documents the upstream-control adoption and requirements.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
An active documentation issue leaves the new 0046 entry outside the Changes table because of an extra blank line.
No open issues 🎉
1 previously missed issue
In code that hasn't changed since last review
Remove blank line so 0046 remains in the Changes table
docs/index.md:24
The blank line before this new row terminates the Markdown table, so the 0046 entry renders as a standalone pipe-delimited paragraph instead of appearing in the Changes table. Remove the separator so this row stays contiguous with 0045.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The landing site duplicated command-copy and theme-toggle controls already suitable for the shared UI library. Use the published upstream controls, remove the local implementations, and keep application-level interaction tests for copy and theme behavior.
Use explicit Tailwind application and library sources so dependency internals are not scanned. Preserve the site's content, layout, and development host configuration.
Contract:
docs/changes/0046-adopt-upstream-ui-controls.mdanddocs/specs/architecture/index.md. This completes 0046. The exact upstream preview0.0.0-a481115is pinned in the dependency manifest and lockfile; it includes the merged packaging and component contributions. Move the pin to a stable release once one includes these changes.Test plan