Repository navigation
feat(skills): install fx/skills for Claude Code, Codex and pi - #11
Merged
Merged
Conversation
Runs the skills CLI on every apply so fx/skills changes are picked up. In Coder the store lives in /shared/agents, linked from both ~/.agents and the shared home so the CLI's relative Claude Code links resolve.
There was a problem hiding this comment.
🟡 Changes recommended
The new installer script and verification/docs have a couple of correctness/robustness issues (shared-home .agents linking behavior and brittle skill verification) that should be fixed before approval.
3 open issues
What changed in this PR
Adds automated installation of fx/skills agent skills as part of the dotfiles apply flow, ensuring Claude Code/Codex/pi have consistent skill content and links (including Coder shared-home persistence considerations).
Changes:
- Add a
run_after_chezmoi script to installfx/skillsvia a pinnedskillsCLI on every apply. - Extend marketplace verification to assert the Claude Code skills links resolve.
- Document the agent-skills installation behavior and Coder persistence model in
CLAUDE.md.
| File | Description |
|---|---|
.chezmoiscripts/run_after_update-agent-skills.sh.tmpl |
New run_after_ script that installs fx/skills for multiple agents and handles Coder shared persistence. |
test/verify-marketplace.sh |
Adds a verification check for resolved Claude Code skill links. |
CLAUDE.md |
Documents the agent-skills install mechanism and shared-home behavior. |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
run_after_update-agent-skills.sh.tmpl, which runsnpx -y skills@1.7.2 add fx/skills --global --skill '*' --agent claude-code codex pi -yon every apply.~/.agents/skills(Codex and pi read it directly), a symlink per skill in~/.claude/skills.run_after_, notrun_onchange_: the script doesn't change when fx/skills does. A no-op re-run takes ~1 s.~/.agentsand$DOTFILES_SHARED_HOME/.agentsboth link to/shared/agents, so the store survives rebuilds and the CLI's relative links (../../.agents/skills/<name>) resolve whether~/.claudeis container-local or a copy in the shared home.test/verify-marketplace.shnow also checks~/.claude/skills/dev/SKILL.mdresolves.Tested: a desktop run (15 Claude Code links, all resolve) and a simulated Coder layout — fresh start and repeat start, with
~/.claudecopied into the shared home in between — 15/15 resolve both times.