Skip to content

chore(claude): drop the fx/cc plugin marketplace - #10

Merged
fx merged 2 commits into
mainfrom
chore/drop-fx-cc-marketplace
Oct 18, 2026
Merged

fx merged 2 commits into
mainfrom
chore/drop-fx-cc-marketplace

Conversation

@fx

@fx fx commented Oct 18, 2026

Copy link
Copy Markdown
Owner

Removes the fx-cc marketplace and its four enabledPlugins entries from .chezmoidata/claude.yaml; skills now come from fx/skills via the skills CLI, outside these dotfiles.

  • test/verify-marketplace.sh checks for the remaining anthropic-agent-skills marketplace instead of fx-cc.
  • CLAUDE.md: the fx/cc marketplace section is replaced by a short note on how the settings merge works — it only adds keys, so existing settings.json files keep the fx-cc entries until removed by hand.

Removes the fx-cc marketplace and its four enabled plugins from the
enforced Claude Code settings. Skills now come from fx/skills via the
skills CLI, which these dotfiles do not manage.
Copilot AI lite review requested due to automatic review settings October 18, 2026 23:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The updated marketplace verification test is now too permissive and should also assert the expected marketplace repo/source to prevent false positives.

1 open issue
What changed in this PR

Removes the fx/cc Claude Code plugin marketplace configuration from this dotfiles repo, keeping only the remaining marketplace configuration and updating documentation/tests to reflect that skills now come from outside these dotfiles.

Changes:

  • Removed the fx-cc marketplace entry and enabledPlugins entries from .chezmoidata/claude.yaml.
  • Updated test/verify-marketplace.sh to validate the remaining marketplace configuration instead of fx-cc.
  • Replaced the fx/cc marketplace documentation in CLAUDE.md with a concise explanation of the non-destructive settings merge behavior.
File Description
test/​verify-marketplace.sh Updates the marketplace verification check to look for the remaining marketplace entry.
CLAUDE.md Replaces fx/cc marketplace docs with guidance about how the settings merge works and its non-deletion behavior.
.chezmoidata/​claude.yaml Removes the fx-cc marketplace and associated enabled plugin declarations, leaving the remaining marketplace config.

Review effort: Lite

Comment thread test/verify-marketplace.sh Resolved

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new jq dependency in test/verify-marketplace.sh should be made explicit/diagnosable, and the repo still contains lingering fx-cc references that should be updated for consistency.

1 open issue
1 previously missed issue

In code that hasn't changed since last review

Low severity Stale fx-cc references remain in docs and scripts

CLAUDE.md:147

This section correctly documents the one-way merge behavior, but there are still repository docs/comments that mention the removed fx-cc marketplace and plugins (e.g. .chezmoiscripts/run_onchange_after_install-codex.sh.tmpl:30 and .claude/skills/chezmoi-development/references/chezmoidata-modify-example.md example JSON). Consider updating/removing those references so the repo consistently reflects the new "skills CLI" approach.

1 resolved since last review

Review effort: Lite

Comment thread test/verify-marketplace.sh Resolved
@fx
fx merged commit 161fd75 into main Oct 18, 2026
4 checks passed
@fx
fx deleted the chore/drop-fx-cc-marketplace branch October 18, 2026 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants