Repository navigation
ops(deploy): placeholder substrate config values; substrate deploy applies its overlay - #202
Merged
Merged
Conversation
…plies its overlay The committed substrate wrangler.jsonc carries a placeholder database id. The substrate deploy job writes its operator overlay over the file from a repository secret before migrations and deploy, the same overwrite the dispatcher deploy job performs, and fails when the secret is absent. Tests, doc comments and docs use example hosts and a fake account id instead of deployment-specific values. AGENTS.md and the docs workflow point at the wrangler configs that carry each custom domain. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The substrate worker's committed config now holds placeholders for account-specific values, matching the dispatcher config. Every org that deploys this repo supplies its own values through an operator overlay.
Problem.
apps/substrate/wrangler.jsonccommitted one deployment's database id and comments describing that account. Several tests, doc comments and docs used that deployment's hostnames and account id as examples. For a BYOC repo, those values mean nothing to any other org that deploys it.Take.
apps/substrate/wrangler.jsonc: the database id is a zero UUID markedoperator overlay. The header explains the overlay and the localwrangler.overlay.local.jsoncconvention, which.gitignorealready covers.deploy.yml: thesubstratejob decodes its overlay secret over the config before migrations and deploy. It fails when the secret is missing, so placeholders never deploy. This matches the dispatcherdeployjob. Thecijob's dry run still runs against the committed placeholders.example.comhosts and a fake account id.AGENTS.md,apps/docs/README.mdanddocs.ymlrefer to each custom domain through thewrangler.jsoncthat routes it.Verification.
pnpm lintandpnpm typecheckpass. The six touched test files pass (157 tests).wrangler deploy --dry-runpasses for both workers, against the placeholder configs and against the overlays.