Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow inline widgets to expand their text line rather than being clipped by a forced strut. Detect
WidgetSpanrecursively so nested syntax-highlighter spans behave the same way. Text-only paragraphs retain their existing fixed strut.This applies to both selectable and non-selectable Markdown. No public API changes.
Validation
Using Flutter 3.44.7 stable / Dart 3.12.2:
flutter test test/inline_widget_test.dart: 7 passed, including six regressions covering tall widgets, nested widget spans, and unchanged text-only struts in both selection modesflutter analyze --no-pub lib/src/builder.dart test/inline_widget_test.dart test/all.dart: passed with no issuesdart format --output=none --set-exit-if-changed --line-length 120 lib/src/builder.dart test/inline_widget_test.dart test/all.dart: passedgit diff --check: passedThe tests use widget geometry and strut assertions, not screenshot/golden updates. The complete suite and device integration tests were not run locally.
Prepared with AI assistance.