Skip to content

feat: measure node expansion latency with browser User Timing - #944

Merged
kumare3 merged 1 commit into
flyteorg:masterfrom
shayansadeghieh:codex/node-expansion-telemetry
Oct 13, 2026
Merged

kumare3 merged 1 commit into
flyteorg:masterfrom
shayansadeghieh:codex/node-expansion-telemetry

Conversation

@shayansadeghieh

@shayansadeghieh shayansadeghieh commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Uses the browser’s Performance API (performance.now() and performance.measure()) to record User Timing entries for expanding a parent row in the Nodes tab. Expansion latency can be inspected in DevTools or collected through PerformanceObserver by benchmarks and telemetry integrations.

flyteconsole.node.expand measures from the expand-arrow click until React commits the expanded child rows. Each entry includes detail.scopedId and detail.executionId (project, domain, name). The boundary is the row commit; it does not wait for browser paint or background requests.

Initial rendering, collapse, and subsequent re-renders do not emit measurements. A newer toggle replaces or cancels the pending measurement. Unsupported timing APIs are ignored, and no reporting dependency or network requests are added.

After expanding a node, inspect the measurements with:

performance.getEntriesByName('flyteconsole.node.expand');

Validation:

  • 10 focused table tests pass, covering click-to-commit timing, metadata, duplicate suppression, collapse/re-expansion, and unsupported APIs.
  • Targeted ESLint and Prettier checks pass (two existing lint warnings).
  • Built a docker image and manually confirmed expansion measurements in Chrome (see attached video)
image

Committed-By-Agent: codex
Co-authored-by: codex <noreply@openai.com>
Signed-off-by: Shayan Sadeghieh <shayansadeghieh@stripe.com>
Committed-By-Agent: codex
Co-authored-by: codex <noreply@openai.com>
@shayansadeghieh
shayansadeghieh force-pushed the codex/node-expansion-telemetry branch from 0458458 to 38e1b22 Compare October 13, 2026 17:07
@kumare3
kumare3 merged commit 6afaddd into flyteorg:master Oct 13, 2026
10 checks passed
@welcome

welcome Bot commented Oct 13, 2026

Copy link
Copy Markdown

Congrats on merging your first pull request! 🎉

@flyte-bot

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 1.23.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants