Repository navigation
feat: measure node expansion latency with browser User Timing - #944
Merged
kumare3 merged 1 commit intoOct 13, 2026
Merged
Conversation
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> Signed-off-by: Shayan Sadeghieh <shayansadeghieh@stripe.com> Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
shayansadeghieh
force-pushed
the
codex/node-expansion-telemetry
branch
from
October 13, 2026 17:07
0458458 to
38e1b22
Compare
kumare3
approved these changes
Oct 13, 2026
|
Congrats on merging your first pull request! 🎉 |
Collaborator
|
🎉 This PR is included in version 1.23.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the browser’s Performance API (
performance.now()andperformance.measure()) to record User Timing entries for expanding a parent row in the Nodes tab. Expansion latency can be inspected in DevTools or collected throughPerformanceObserverby benchmarks and telemetry integrations.flyteconsole.node.expandmeasures from the expand-arrow click until React commits the expanded child rows. Each entry includesdetail.scopedIdanddetail.executionId(project,domain,name). The boundary is the row commit; it does not wait for browser paint or background requests.Initial rendering, collapse, and subsequent re-renders do not emit measurements. A newer toggle replaces or cancels the pending measurement. Unsupported timing APIs are ignored, and no reporting dependency or network requests are added.
After expanding a node, inspect the measurements with:
Validation: