Repository navigation
chore(deps): bump aiohttp from 3.14.3 to 3.14.4 in /test/gha-e2e/mooncake/image - #6212
dependabot[bot] wants to merge 1 commit into
Conversation
--- updated-dependencies: - dependency-name: aiohttp dependency-version: 3.14.4 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
There was a problem hiding this comment.
🟡 Changes recommended
The existing yarl pin conflicts with aiohttp 3.14.4’s verified dependency requirement, preventing dependency resolution.
No open issues 🎉
What changed in this PR
Updates the aiohttp dependency used by the Mooncake end-to-end test image.
Changes:
- Bumps aiohttp from 3.14.3 to 3.14.4.
- Replaces the previous artifact hash with an expanded SHA-256 hash list.
| File | Description |
|---|---|
test/gha-e2e/mooncake/image/requirements.txt |
Updates the aiohttp version pin and artifact hashes. |
Review effort: Balanced
cheyang
left a comment
cheyang
left a comment
There was a problem hiding this comment.
Both reviewers independently confirmed the same blocker: this bump breaks the mooncake e2e image's hash-locked requirements. aiohttp 3.14.4 now requires yarl<2.0,>=1.25.1, but the lock still pins yarl==1.24.5, so the Dockerfile's pip install --only-binary=:all: --require-hashes fails with ResolutionImpossible — all five kind-e2e-test jobs on this PR are red (run 39403532072, the only failing E2E Functionality Check run in recent history) while every other check passes and neighbouring dependabot bumps to the same file stay green. We reproduced it locally with the Dockerfile's exact pip flags (head fails, merge-base passes) and verified the fix shape: bump the yarl entry to yarl==1.25.1 with --hash=sha256:c6f117789d22dce188e5754e8bc65b7e6ebf8cb73963b9fa761f672a5883769d — with that one change the full lock resolves cleanly, and yarl is the only broken floor.
The premise itself is sound — this is a legitimate security bump (several 2026-10-19/20 advisories list <=3.14.3 as vulnerable, first patched in 3.14.4) — the generated lock is just incomplete.
Next round
[MUST] Bump yarl to 1.25.1 alongside aiohttp (--hash=sha256:c6f117789d22dce188e5754e8bc65b7e6ebf8cb73963b9fa761f672a5883769d), or regenerate the lock per the file header's documented procedure, so the file resolves under pip install --only-binary=:all: --require-hashes.
[SHOULD] Prefer the header's regeneration procedure over the 161-hash dependabot list — it emits one wheel hash per package, matching the file's convention and shrinking future diffs (appendix).
[SHOULD] Maintainer decision on who completes hash-locked dependabot bumps when transitive floors move, and optionally a ~30s pip-resolution precheck job for test/gha-e2e/**/requirements.txt changes (appendix).
[Filed] none.
Reviewer disagreement: none — the two debaters fully agreed, including in cross-critique. Reviewer C (Copilot) reviewed this head and raised no findings.
Non-blocking observations (3) — not part of this round's ask; fix now, follow up, or file an issue as you see fit
- .github/dependabot.yml [minor]
Who completes Dependabot bumps of hash-locked requirements when transitive floors move? - test/gha-e2e/mooncake/image/requirements.txt:26 [nit]
nit: regenerated aiohttp entry carries 161 hashes instead of the file's one-wheel-hash convention - .github/workflows [nit]
nit: add a fast pip-resolution precheck for changes to test/gha-e2e/**/requirements.txt
Verified review delta
- F1-yarl-lock-conflict: open (initial-pr)
- F2-dependabot-lockfile-ownership: open (initial-pr)
- F2-hash-list-convention: open (initial-pr)
- F3-fast-lockfile-precheck: open (initial-pr)
Code: needs-work. CI: failure; attribution: pr-regression. Required CI checks still apply.
| # via mooncake-transfer-engine-non-cuda | ||
| aiohttp==3.14.3 \ | ||
| --hash=sha256:543906c127fb1d929b95076db19b83fa2d46751006ff1e23b093aa5ac4d8db42 | ||
| aiohttp==3.14.4 \ |
There was a problem hiding this comment.
F1 (consensus, both reviewers): this PR bumps the aiohttp entry from 3.14.3 to 3.14.4 but leaves yarl==1.24.5 pinned (line 400), and aiohttp 3.14.4 now requires yarl<2.0,>=1.25.1 (3.14.3 required only >=1.17.0). The image Dockerfile installs with pip install --only-binary=:all: --require-hashes, so the resolver hits ResolutionImpossible and the image build fails — all five kind-e2e-test jobs on this PR are red, and merging as-is would turn master's kind-e2e red for every subsequent PR. Dependabot rewrites only the bumped package's entry in a hash-locked file; it cannot re-resolve the other pins, so a moved transitive floor lands as an inconsistent lock. Fix (verified green by both harnesses' fixcheck runs): also bump the yarl entry to yarl==1.25.1 with --hash=sha256:c6f117789d22dce188e5754e8bc65b7e6ebf8cb73963b9fa761f672a5883769d, or regenerate the whole lock with the procedure documented in the file header. yarl 1.25.1's own floors (idna>=2.0, multidict>=4.0, propcache>=0.2.1) are satisfied by the existing pins, so the single-entry bump is sufficient.
Bumps aiohttp from 3.14.3 to 3.14.4.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.