Repository navigation
Retry the release smoke test if ADB drops the emulator - #117
Merged
Merged
Conversation
The release smoke step fails when ADB loses the emulator mid-run
("adb: device 'emulator-5554' not found"), although the app is fine.
Upstream fixed this in 621a94b by running the test through
.github/run_release_smoke_test.py, which retries once only if ADB
reconnected and the test never reported a result.
The upstream sync brings the script but not the change to our copy of
the emulator workflow, so add the script unchanged and call it from
ankiquest_tests_emulator.yml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What failed
"Android Emulator Test (36, x86_64, google_apis, 600, 0)" fails in the Run Release Smoke Test step on several PRs, after the main instrumented tests pass, e.g. #113 and the first attempt of #111 (it passed on rerun):
Cause
Not the AnkiQuest branding:
ReleaseSmokeTestreads the package fromtargetAppId, and the step passes on most PRs. ADB loses the emulator partway through the run, so the test never finishes and AGP reports it as failed. Upstream fixed this in ankidroid/Anki-Android@621a94b946 ("ci(emulator): retry the smoke test if ADB drops") with.github/run_release_smoke_test.py. It retries once, and only when ADB reconnected and the test reported no result. A real test failure is never retried, and a run that passes without any test result now fails.The daily upstream sync brings that script and the change to
tests_emulator.yml, but our copy,ankiquest_tests_emulator.yml, still calls Gradle directly.Fix
.github/run_release_smoke_test.py, byte-identical to upstream, so the next sync merges cleanly.ankiquest_tests_emulator.ymlthe way upstream's workflow does.No upstream files change.