Repository navigation
Point the fork workflows at main after the branch rename - #106
Merged
Merged
Conversation
The default branch moved from ankiquest to main, but the ankiquest_* workflows still named ankiquest. The upstream sync and flake.lock jobs failed checking out a branch that no longer exists, and pushes to main skipped the APK (so no nightly), lint, emulator, nix, fixtures and signing checks. The sync job now also tries the upstream merge and lists conflicting files in a warning and the job summary. The scheduled emulator run no longer skips itself on forks, so the weekly run happens here.
|
Snapshot diff report: Previous regressions were resolved by the latest commit. |
# Conflicts: # .github/workflows/ankiquest_tests_unit.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default branch was renamed from
ankiquesttomainafter #93, but theankiquest_*workflows still pointed atankiquest:mainand open their PRs intomain. The sync job finds an openankidroid:main→mainPR such as sync #104 and leaves it alone.nix flake updateitself works (tried on NixOS: it bumps nixpkgs 2026-10-27 → 2026-11-01) and so doesnix flake check.main,ankiquest APK(so no nightly release),ankiquest Code Quality Checks,ankiquest Emulator Tests,ankiquest Nix,ankiquest shared fixturesandankiquest signing key rotationnever ran, and the fixtures check also skipped PRs intomain. Theirbranches:filters and the nightlyrefs/heads/ankiquestcheck now saymain.ankiquest Unit Testsgets the same change in Run fork PR unit tests on ubuntu only #105, so it isn't touched here.ankiquest Screenshots: Store Baselinedropsankiquest, and the workflow regression tests stop asking for anankiquestbaseline.The sync job also tries the upstream merge before it opens or reuses the PR. Conflicting files go into a warning and the job summary, so the run says what to resolve in the merge branch (it currently lists
gradle/libs.versions.toml). A conflict doesn't fail the job, because a daily red run would only repeat what the PR already shows.ankiquest Emulator Testsstill had upstream's "don't run scheduled jobs on forks" guard, so its weekly Monday run skipped itself every time (2026-11-02). That guard is gone; this is the same change #105 makes for unit tests.Other failures on main, nothing to change
tests_unit.yml, which should be disabled as Keep fork CI in ankiquest_* workflows, restore upstream .github #88 lists.mainyet, because it was the first push to the renamed branch and Store Baseline ran at the same time. That Store run succeeded (run 41427799883, artifact kept until 2026-12-02), and later compares find it (Run fork PR unit tests on ubuntu only #105's compare passed). Rerun that compare if you want main green. It fails on a missing baseline on purpose (see.github/tests/screenshots.test.cjs).actionlintis clean apart from existing shellcheck info notes, andnode --test .github/tests/*.test.cjspasses.