Repository navigation
Conversation
1dac8600 Merge branch 'wip/smcv/asan' into 'master'
2ed30d8a Merge branch 'wip/smcv/symlink-xattr' into 'master'
4be465ee CI: Build with Address Sanitizer and UB Sanitizer
d9cd2402 tests: Assert that xattrs on a symlink can be copied, if we are root
324a09f2 fdio: Don't try to use fd-relative operations to set symlink xattrs
f05eb431 Revert "xattrs: Use /proc/self/fd path in glnx_fd_get_all_xattrs"
54c19286 Revert "xattrs: Use /proc/self/fd path in glnx_fd_set_all_xattrs"
846e1757 Revert "xattrs: Drop fd-based code paths from get_xattrs_impl"
fa34fbe4 Merge branch 'wip/smcv/issue8' into 'master'
001aa73d tests: Try to test copying of a symlink we don't own
ff780240 fdio: Don't change ownership of symlinks if not requested
813d8d17 Merge branch 'wip/smcv/ci' into 'master'
4cae78cd Merge branch 'wip/automount-bug' into 'master'
430f4b9b CI: Stop building in EOL Fedora 30
6cee0095 CI: Build in some old branches of Ubuntu LTS
acc7c5db CI: Do a build in Steam Linux Runtime version 1
ab648ed2 CI: Add a Debian 10 build
4350364e CI: Fall back to using `git archive` if `meson dist` is unimplemented
9dd30453 CI: Use `meson setup $builddir` instead of deprecated `meson $builddir`
a2791fe9 CI: Use Debian testing in preference to unstable
a2a3992f build: Suppress `-Wmissing-field-initializers`
9f587b90 fdio: Pre-declare `struct file_handle`
93cb86b2 Merge branch 'bbhtt/add-ci' into 'master'
05fb0317 ci: Add build job for Fedora latest, rawhide, debian stable and unstable
6a697e50 ci: Factor out build job into template
b22c8a0d Merge branch 'wip/fix-automount-comment' into 'master'
84d5788e chase: Fix incorrect comment in chase_open_tree automount fallback
c3de377c chase: Pass NO_AUTOMOUNT to chase_open_tree in shortcut path
c18b9671 Merge branch 'wip/file-copy-at-symlink-chown' into 'master'
5764006e tests: Add test for copying symlinks
6bb03208 glnx_file_copy_at: Use O_PATH fd for xattr and ownership operations
036ad700 xattrs: Drop fd-based code paths from get_xattrs_impl
128578be xattrs: Use /proc/self/fd path in glnx_fd_set_all_xattrs
fc9387a7 xattrs: Use /proc/self/fd path in glnx_fd_get_all_xattrs
39034945 Merge branch 'wip/openat2-eagain' into 'master'
eef7f14c chase: Handle EAGAIN from openat2
8ef5ee94 Merge branch 'wip/chase-callback' into 'master'
ae735561 chase: Add glnx_chase_and_mkdirat
4f867470 chase: Add internal glnx_chaseat_full for a strategic callback
c88d9f22 Merge branch 'wip/meson-override-dependency' into 'master'
ff64d521 Merge branch 'wip/name-to-handle-at' into 'master'
015ec9c6 fdio: Add support for name_to_handle_at
72b1d539 build: Add meson.override_dependency('libglnx', libglnx_dep)
c8bebf47 Merge branch 'wip/smcv/autofd' into 'master'
346eaf62 Merge branch 'bbhtt/glib-wrap' into 'master'
dbc0d4f5 backports: Wrap g_clear_fd to silence deprecations for newer Glib
b478f3e7 tests: Assert that glnx_close_fd preserves errno
606dbdbc testlib: Add an assertion that a fd has really been closed
1c391d73 backports, local-alloc: Provide a backport of g_autofd
ccea836b Merge branch 'wip/smcv/autotools' into 'master'
e3006ead build: Include glnx-chase in the Autotools build system, too
git-subtree-dir: subprojects/libglnx
git-subtree-split: 1dac8600aee2f52411478f5e77a0ccfef1850ba0
Collaborator
Author
|
I think we need to bump the glib requirements and the GLIB_VERSION_* macros to 2.76 at least here. The CI has GLib >= 2.76, so libglnx's own backports have no effect, so we use GLib's own g_autofd which gets caught in our 2.66 minimum requirement. |
Latest libglnx defines glnx_autofd and glnx_fd_close in terms of g_autofd. When building against GLib >= 2.76, libglnx uses GLib's own g_autofd rather than its backport, and GLib marks that macro as available since 2.76. With GLIB_VERSION_MAX_ALLOWED at 2.70 this triggers "Not available before 2.76" and, with -Werror, fails the build. Allow the 2.76 API so the real g_autofd can be used. The minimum required GLib version stays at 2.66, since libglnx provides a g_autofd backport for older versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.