[CharlesOmeneki]

Summary

• Read platform-specific ripgrep versions from binaries.lock.json for vscode-ripgrep 1.18.0 and newer.
• Preserve the existing postinstall.js version lookup for older releases.

Testing

• python -m compileall flatpak_node_generator
• python -m pytest -q — 42 passed, 43 deselected.
• git diff --check

[zhsj]

I don't know much about how js/npm works. But it looks like since 1.18.0 there's no need to handle vscode-ripgrep. The binary package is now in pnpm-lock.yaml.

  '@vscode/ripgrep-darwin-arm64@1.18.0':
    resolution: {integrity: sha512-r3ktHSvbFycQNF6sl7sNDPocpsI7J+mEzh1IaZFkY0spm3k2Z9t8hPAeOK7+p0l6p6/swkQC14XWX01low+94Q==}
    cpu: [arm64]
    os: [darwin]

  '@vscode/ripgrep-darwin-x64@1.18.0':
    resolution: {integrity: sha512-25b4gWbL138dGuQU244ebCKKc0q05ULBMoFSz9oAEUHNeqK/lOJViDS7DRvbDazzAzSEdan391Znks/R5mkaTQ==}
    cpu: [x64]
    os: [darwin]

  '@vscode/ripgrep-linux-arm64@1.18.0':
    resolution: {integrity: sha512-lQ/5zTG++U0E3IhVgS4EPTTn/U4okncaRMM5GOFfOYZywS4nuD31GhkHbNYlDk5CuDC68+hYJ0/eQeyCKJDA+g==}
    cpu: [arm64]
    os: [linux]

[CharlesOmeneki]

Thanks for pointing this out, @zhsj. I hadn't considered that the binary packages might now be handled through pnpm-lock.yaml.

I'll investigate whether the existing generator can handle these packages directly, and whether the special vscode-ripgrep handling is still needed for 1.18.0 and newer before making further changes.

[CharlesOmeneki]

Thanks for the clarification, @zhsj. I confirmed that @vscode/ripgrep 1.18.0 no longer includes lib/postinstall.js and declares platform-specific packages such as @vscode/ripgrep-linux-x64 as optional dependencies.

The pnpm provider processes resolved lockfile packages as tarball sources, so I’m investigating whether the special handler should be skipped for @vscode/ripgrep 1.18.0 and newer. Would you prefer that approach, or should I keep the binaries.lock.json handling in the PR?

[bbhtt]

I'm not looking at PRs with AI generated descriptions. You are not welcome to open more of these.