Skip to content

Support pnpm v12 - #559

Merged
bbhtt merged 3 commits into
flatpak:masterfrom
aervxa:patch-1
Sep 30, 2026
Merged

bbhtt merged 3 commits into
flatpak:masterfrom
aervxa:patch-1

Conversation

@aervxa

@aervxa aervxa commented Sep 28, 2026

Copy link
Copy Markdown

closes #555

pnpm 11+ creates an "internal" docuemnt for it's own deps, and that is prepended. so the last yaml document is the lockfile. this works for older versions too because "last document" is the first, last, and only document in their single document structure

this is afaik, if I'm mistaken, please correct me :>

@aervxa
aervxa requested a review from bbhtt as a code owner September 28, 2026 10:20
@github-actions github-actions Bot added the node label Sep 28, 2026
@bbhtt

bbhtt commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator

can you add a test with a v12 lockfile too?

pnpm v12 still uses store version 11
@aervxa

aervxa commented Sep 28, 2026

Copy link
Copy Markdown
Author

my fault, pnpm v12 still uses store version 11.

@aervxa

aervxa commented Sep 28, 2026

Copy link
Copy Markdown
Author

can you add a test with a v12 lockfile too?

How should I exactly do this? there is existing tests for lockfile_version 9
and pnpm v12 still uses that

@YUCLing

YUCLing commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

@aervxa

How should I exactly do this?

Although it's still version 9, but the lockfile itself's format has been changed, which will possibly contain multiple documents, that's what you can test for. I think.

@aervxa

aervxa commented Sep 28, 2026

Copy link
Copy Markdown
Author

Although it's still version 9, but the lockfile itself's format has been changed, which will possibly contain multiple documents, that's what you can test for. I think.

The python testing code is a little too unfamiliar to me 😕 I'll see what I can do.

@aervxa

aervxa commented Sep 28, 2026

Copy link
Copy Markdown
Author

A stolen copy of the existing test_lockfile_v9, It passed.

@bbhtt
bbhtt merged commit 74697c7 into flatpak:master Sep 30, 2026
4 checks passed
@aervxa
aervxa deleted the patch-1 branch October 1, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support pnpm v12

3 participants