Repository navigation
[2.x] fix(likes): order likers with the same like time by user id - #5403
Open
karl-bullock wants to merge 1 commit into
Open
karl-bullock wants to merge 1 commit into
karl-bullock wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Likes are stored to the second, so likers who liked in the same second came back in whatever order the database returned them. That decides which four likers a post lists, so the response could change between requests or database servers.
This adds
user_idas a final tie-breaker after the actor-first andcreated_atordering, as suggested in the issue.Fixes #5244
The new test gives one post ten likes with an identical
created_at, inserted out of id order. It checks that a non-liker gets the likers in user id order and the same on a second request, and that a liker still sees themselves first. On SQLite the primary key index already returns ties in id order, so the test passes there with or without the change; it pins the behavior for other drivers.