Repository navigation
fix(core,web): honour flutterfire_ignore_scripts under dart2wasm - #18806
Conversation
JS arrays are not Dart Iterables on dart2wasm, so the ignore list was always empty and skipped service scripts still loaded. Read the window value as a JSArray on both compilers.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
Description
window.flutterfire_ignore_scriptsis used to skip auto-injecting selected Firebase JS SDKs (for example Analytics until the user consents)._ignoredServiceScriptstreated that window value as a DartIterable. That is true under dart2js, where a JS array is a DartList, but false under dart2wasm, where it stays aJSArray. Wasm builds therefore always saw an empty ignore list and still injected the scripts.This PR reads the property as a
JSArrayviaisAon theJSAny?fromgetProperty(available on Dart 3.6+, which this package still supports) and converts entries withJSString.toDart.Related Issues
Fixes #18804
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
Test plan
In
packages/firebase_core/firebase_core_web:flutter test --platform chrome— dart2js, including the new ignore-scripts testsflutter test --platform chrome --wasm— dart2wasm; the JS-array case failed on main and passes with this changefirebase_core_web